Bug 200351 - Update Test262 (2019.08.01)
Summary: Update Test262 (2019.08.01)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-01 10:51 PDT by Ross Kirsling
Modified: 2019-08-01 12:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.05 MB, patch)
2019-08-01 10:53 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-08-01 10:51:32 PDT 
Update Test262 (2019.08.01)
Comment 1 Ross Kirsling 2019-08-01 10:53:57 PDT 
Created attachment 375324 [details]
Patch
Comment 2 Keith Miller 2019-08-01 11:26:25 PDT 
Comment on attachment 375324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375324&action=review

rs=me with question.

> JSTests/test262/expectations.yaml:-2156
> -test/intl402/NumberFormat/prototype/resolvedOptions/order.js:
> -  default: 'Test262Error: Expected [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] and [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] to have the same contents. undefined'
> -  strict mode: 'Test262Error: Expected [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] and [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] to have the same contents. undefined'
> -test/intl402/fallback-locales-are-supported.js:
> -  default: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-Hans isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with Collator.)"
> -  strict mode: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-Hans isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with Collator.)"

What happened here?
Comment 3 Ross Kirsling 2019-08-01 11:42:42 PDT 
(In reply to Keith Miller from comment #2)
> Comment on attachment 375324 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375324&action=review
> 
> rs=me with question.
> 
> > JSTests/test262/expectations.yaml:-2156
> > -test/intl402/NumberFormat/prototype/resolvedOptions/order.js:
> > -  default: 'Test262Error: Expected [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] and [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] to have the same contents. undefined'
> > -  strict mode: 'Test262Error: Expected [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumFractionDigits, maximumFractionDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] and [locale, numberingSystem, style, currency, currencyDisplay, minimumIntegerDigits, minimumSignificantDigits, maximumSignificantDigits, useGrouping] to have the same contents. undefined'
> > -test/intl402/fallback-locales-are-supported.js:
> > -  default: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-Hans isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with Collator.)"
> > -  strict mode: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-Hans isn't. Expected SameValue(ë-1û, ë-1û) to be false (Testing with Collator.)"
> 
> What happened here?

Looks like https://github.com/tc39/test262/commit/8b725e3957085602a7a6766ca464cf3984c9313b added "features: [Intl.NumberFormat-unified]", which is on our ignore list.
Comment 4 WebKit Commit Bot 2019-08-01 12:12:41 PDT 
Comment on attachment 375324 [details]
Patch

Clearing flags on attachment: 375324

Committed r248115: <https://trac.webkit.org/changeset/248115>
Comment 5 WebKit Commit Bot 2019-08-01 12:12:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-01 12:13:17 PDT 
<rdar://problem/53826677>