Bug 20035 - [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()
Summary: [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Wouter Bolsterlee
Depends on:
Reported: 2008-07-14 16:51 PDT by Wouter Bolsterlee
Modified: 2008-08-01 22:20 PDT (History)
0 users

See Also:

Proposed fix (1.28 KB, patch)
2008-07-14 16:54 PDT, Wouter Bolsterlee
no flags Details | Formatted Diff | Diff
Updated patch (1.24 KB, patch)
2008-07-14 17:12 PDT, Wouter Bolsterlee
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wouter Bolsterlee 2008-07-14 16:51:58 PDT
Currently webkit_web_view_go_to_back_forward_item() always returns TRUE. There's a FIXME in the code to change this. Find attached a patch that changes this into a more suitable return value.

Note that the Objective-C docs at http://developer.apple.com/documentation/Cocoa/Reference/WebKit/Classes/WebView_Class/Reference/Reference.html#//apple_ref/occ/instm/WebView/goToBackForwardItem: seem to suggest this approach as well.
Comment 1 Wouter Bolsterlee 2008-07-14 16:54:55 PDT
Created attachment 22274 [details]
Proposed fix
Comment 2 Wouter Bolsterlee 2008-07-14 17:06:07 PDT
02:03:33 < bdash> uws: https://bugs.webkit.org/attachment.cgi?id=22274&action=prettypatch -- the 
                  declaration and assignment should be on the same line, and the variable name 
                  should match our coding style guidelines
Comment 3 Wouter Bolsterlee 2008-07-14 17:12:42 PDT
Created attachment 22275 [details]
Updated patch
Comment 4 Eric Seidel (no email) 2008-08-01 17:00:43 PDT
Comment on attachment 22275 [details]
Updated patch

Looks fine.
Comment 5 Jan Alonzo 2008-08-01 22:20:24 PDT
landed in r35522