Bug 200347 - results.webkit.org: Collision detection for dots is off by 2 * dotMargin
Summary: results.webkit.org: Collision detection for dots is off by 2 * dotMargin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-01 09:28 PDT by Jonathan Bedard
Modified: 2019-08-01 12:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2019-08-01 09:29 PDT, Jonathan Bedard
jbedard: commit-queue-
Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2019-08-01 10:17 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-08-01 09:28:11 PDT
Messing around with the canvas timeline, our collision detection isn't quite right. It's definitely the dotMargin.
Comment 1 Jonathan Bedard 2019-08-01 09:29:46 PDT
Created attachment 375315 [details]
Patch
Comment 2 Jonathan Bedard 2019-08-01 09:31:24 PDT
This patch 'fixes' the problem, but it's definitely the wrong way to do it. It feels like the actual x value of the dots is wrong.
Comment 3 Zhifei Fang 2019-08-01 10:17:22 PDT
Created attachment 375321 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-01 12:43:09 PDT
Comment on attachment 375321 [details]
Patch

Clearing flags on attachment: 375321

Committed r248117: <https://trac.webkit.org/changeset/248117>
Comment 5 WebKit Commit Bot 2019-08-01 12:43:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-01 12:44:17 PDT
<rdar://problem/53827885>