Bug 20034 – [GTK] Invalid vim modeline in WebCore/plugins/gtk/gtk2xtbin.h (with patch)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Wouter Bolsterlee]

The vim modeline in WebCore/plugins/gtk/gtk2xtbin.h is malformed, causing an error when this file is opened in Vim.

(I'm atrevision 35167)

[Wouter Bolsterlee]

Created attachment 22273 [details]
Fix malformed Vim modeline

[Eric Seidel (no email)]

Comment on attachment 22273 [details]
Fix malformed Vim modeline

Looks sane enough.

Seems we should have a script to add WebKit-style compatible mode-lines to all files if we're going to use them.  It's silly to go through and fix each one by hand.

[Jan Alonzo]

landed in r35526

[Wouter Bolsterlee]

(In reply to comment #2)
> Seems we should have a script to add WebKit-style compatible mode-lines to all
> files if we're going to use them.  It's silly to go through and fix each one by
> hand.

Perhaps a sample Vim configuration file snippet can be placed somewhere in the WebKit tree. Some comments can be added to tell people how to use it, e.g. tell them to place something like this in their ~/.vimrc:

  autocmd BufReadPost /path/to/your/webkit/tree/* source /patch/to/your/webkit/tree/webkit.vim

Anyway, nothing major, so leaving this report RESOLVED FIXED.