Bug 200323 - Rename DOMJIT safe/unsafeFunction to functionWithTypeChecks and functionWithoutTypeChecks.
Summary: Rename DOMJIT safe/unsafeFunction to functionWithTypeChecks and functionWitho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 200292
  Show dependency tree / graph
 
Reported: 2019-07-31 16:19 PDT by Mark Lam
Modified: 2019-08-01 10:15 PDT (History)
12 users (show)

See Also:

Attachments
proposed patch. (27.57 KB, patch)
2019-07-31 16:38 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-07-31 16:19:40 PDT 
...
Comment 1 Mark Lam 2019-07-31 16:38:18 PDT 
Created attachment 375267 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-07-31 16:44:21 PDT 
Comment on attachment 375267 [details]
proposed patch.

r=me
Comment 3 Geoffrey Garen 2019-07-31 20:29:37 PDT 
Comment on attachment 375267 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=375267&action=review

> Source/JavaScriptCore/domjit/DOMJITSignature.h:40
> +using FunctionWithoutTypeCheck = void (*)();

I think I would call this CFunctionPointer. This type can point to any C function.
Comment 4 Mark Lam 2019-08-01 10:07:44 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 375267 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375267&action=review
> 
> > Source/JavaScriptCore/domjit/DOMJITSignature.h:40
> > +using FunctionWithoutTypeCheck = void (*)();
> 
> I think I would call this CFunctionPointer. This type can point to any C
> function.

I'm going to land this as is for now.  We'll probably change this again in https://bugs.webkit.org/show_bug.cgi?id=200292 after we find a better expression of the type.
Comment 5 Mark Lam 2019-08-01 10:14:42 PDT 
Thanks for the reviews.  Landed in r248105: <http://trac.webkit.org/r248105>.
Comment 6 Radar WebKit Bug Importer 2019-08-01 10:15:34 PDT 
<rdar://problem/53820228>