Bug 200317 - UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
Summary: UserMediaPermissionRequestManagerProxy should not use audio+video denied requ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-31 14:38 PDT by youenn fablet
Modified: 2019-08-01 09:18 PDT (History)
8 users (show)

See Also:


Attachments
Patch (10.16 KB, patch)
2019-07-31 14:42 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (11.55 KB, patch)
2019-07-31 14:51 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.94 MB, application/zip)
2019-07-31 15:56 PDT, Build Bot
no flags Details
Patch (17.21 KB, patch)
2019-07-31 16:36 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-31 14:38:43 PDT
UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
Comment 1 youenn fablet 2019-07-31 14:42:01 PDT
Created attachment 375248 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-07-31 14:44:04 PDT
<rdar://problem/53781486>
Comment 3 youenn fablet 2019-07-31 14:51:55 PDT
Created attachment 375252 [details]
Patch
Comment 4 Build Bot 2019-07-31 15:56:22 PDT
Comment on attachment 375252 [details]
Patch

Attachment 375252 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12843432

New failing tests:
fast/mediastream/getUserMedia-deny-persistency3.html
Comment 5 Build Bot 2019-07-31 15:56:23 PDT
Created attachment 375263 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 Eric Carlson 2019-07-31 16:33:04 PDT
Comment on attachment 375252 [details]
Patch

r=me once the bots are happy
Comment 7 youenn fablet 2019-07-31 16:36:19 PDT
Created attachment 375266 [details]
Patch
Comment 8 WebKit Commit Bot 2019-08-01 09:18:02 PDT
Comment on attachment 375266 [details]
Patch

Clearing flags on attachment: 375266

Committed r248104: <https://trac.webkit.org/changeset/248104>
Comment 9 WebKit Commit Bot 2019-08-01 09:18:04 PDT
All reviewed patches have been landed.  Closing bug.