Bug 200309 - [ContentChangeObserver] twitch.tv video controls do not always respond to taps in fullscreen
Summary: [ContentChangeObserver] twitch.tv video controls do not always respond to tap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-31 11:45 PDT by zalan
Modified: 2019-07-31 16:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.37 KB, patch)
2019-07-31 11:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.30 KB, patch)
2019-07-31 13:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.66 KB, patch)
2019-07-31 14:05 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-07-31 11:45:53 PDT 
<rdar://problem/52964977>
Comment 1 zalan 2019-07-31 11:55:55 PDT 
Created attachment 375232 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-07-31 12:44:05 PDT 
Comment on attachment 375232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375232&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:108
> +    if (auto* activeFullscreenElement = fullscreenElement(node.document()))
> +        return !node.isDescendantOf(*activeFullscreenElement);

This doesn't handle the case of a subframe inside a fullscreen element.
Comment 3 zalan 2019-07-31 13:02:25 PDT 
Created attachment 375239 [details]
Patch
Comment 4 zalan 2019-07-31 14:05:43 PDT 
Created attachment 375241 [details]
Patch
Comment 5 WebKit Commit Bot 2019-07-31 16:01:48 PDT 
Comment on attachment 375241 [details]
Patch

Clearing flags on attachment: 375241

Committed r248080: <https://trac.webkit.org/changeset/248080>
Comment 6 WebKit Commit Bot 2019-07-31 16:01:50 PDT 
All reviewed patches have been landed.  Closing bug.