Bug 200293 – REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

Increment FrameView's visually non-empty pixel count by a video's natural size

[Andy Estes]

Created attachment 375208 [details]
Patch

[Andy Estes]

<rdar://problem/52937749>

[EWS Watchlist]

Attachment 375208 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 375271 [details]
Patch

[Andy Estes]

Created attachment 375272 [details]
Patch

[Alex Christensen]

Comment on attachment 375272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375272&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:125
> +    [configuration setAllowsInlineMediaPlayback:YES];

This obviously doesn't exist on Mac. Once it builds, r=me

[Simon Fraser (smfr)]

Comment on attachment 375272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375272&action=review

> Source/WebCore/ChangeLog:21
> +        In order for these HTMLDocument subclasses to be considered visually non-empty before they
> +        finish loading they must render something that exceeds the visual character or pixel

I don' know if these media document should even do any throttling. Why don't we just not throttle them?

[Andy Estes]

(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 375272 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375272&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        In order for these HTMLDocument subclasses to be considered visually non-empty before they
> > +        finish loading they must render something that exceeds the visual character or pixel
> 
> I don' know if these media document should even do any throttling. Why don't
> we just not throttle them?

Video documents are pretty flashy otherwise. You see the video element start out at a default size then resize once the video metadata loads. You also see a lot of media control flashiness.

[Andy Estes]

Created attachment 375280 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375280 [details]
Patch

Clearing flags on attachment: 375280

Committed r248095: <https://trac.webkit.org/changeset/248095>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.