Bug 200293 - REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
Summary: REGRESSION (r240942): first visually non-empty layout milestone is not reache...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-30 22:33 PDT by Andy Estes
Modified: 2019-07-31 21:25 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.60 KB, patch)
2019-07-30 22:34 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (25.99 KB, patch)
2019-07-31 17:16 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (21.91 KB, patch)
2019-07-31 17:22 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (21.93 KB, patch)
2019-07-31 19:51 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-07-30 22:33:48 PDT Comment hidden (obsolete)
Comment 1 Andy Estes 2019-07-30 22:34:31 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2019-07-30 22:34:32 PDT
<rdar://problem/52937749>
Comment 3 Build Bot 2019-07-30 22:36:06 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2019-07-31 17:16:22 PDT Comment hidden (obsolete)
Comment 5 Andy Estes 2019-07-31 17:22:15 PDT
Created attachment 375272 [details]
Patch
Comment 6 Alex Christensen 2019-07-31 17:43:23 PDT
Comment on attachment 375272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375272&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:125
> +    [configuration setAllowsInlineMediaPlayback:YES];

This obviously doesn't exist on Mac. Once it builds, r=me
Comment 7 Simon Fraser (smfr) 2019-07-31 17:54:17 PDT
Comment on attachment 375272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375272&action=review

> Source/WebCore/ChangeLog:21
> +        In order for these HTMLDocument subclasses to be considered visually non-empty before they
> +        finish loading they must render something that exceeds the visual character or pixel

I don' know if these media document should even do any throttling. Why don't we just not throttle them?
Comment 8 Andy Estes 2019-07-31 18:05:04 PDT
(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 375272 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375272&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        In order for these HTMLDocument subclasses to be considered visually non-empty before they
> > +        finish loading they must render something that exceeds the visual character or pixel
> 
> I don' know if these media document should even do any throttling. Why don't
> we just not throttle them?

Video documents are pretty flashy otherwise. You see the video element start out at a default size then resize once the video metadata loads. You also see a lot of media control flashiness.
Comment 9 Andy Estes 2019-07-31 19:51:47 PDT
Created attachment 375280 [details]
Patch
Comment 10 WebKit Commit Bot 2019-07-31 21:25:08 PDT
Comment on attachment 375280 [details]
Patch

Clearing flags on attachment: 375280

Committed r248095: <https://trac.webkit.org/changeset/248095>
Comment 11 WebKit Commit Bot 2019-07-31 21:25:09 PDT
All reviewed patches have been landed.  Closing bug.