Bug 200288 - Fix 64-bit vs 32-bit mismatch in PersistentCoders.h
Summary: Fix 64-bit vs 32-bit mismatch in PersistentCoders.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-30 16:33 PDT by Keith Rollin
Modified: 2019-07-31 09:27 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2019-07-30 16:34 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-07-30 16:33:06 PDT
hashMapSize is declared as a uint64_t. It is passed to HashMapType::reserveInitialCapacity, which takes an unsigned int. This is a 32-bit value on 32-bit platforms, leading to a compile time error. Fix his by casting hashMapSize to the expected type.
Comment 1 Radar WebKit Bug Importer 2019-07-30 16:33:18 PDT
<rdar://problem/53734203>
Comment 2 Keith Rollin 2019-07-30 16:34:32 PDT
Created attachment 375195 [details]
Patch
Comment 3 WebKit Commit Bot 2019-07-31 09:27:02 PDT
Comment on attachment 375195 [details]
Patch

Clearing flags on attachment: 375195

Committed r248044: <https://trac.webkit.org/changeset/248044>
Comment 4 WebKit Commit Bot 2019-07-31 09:27:04 PDT
All reviewed patches have been landed.  Closing bug.