Bug 200283 – Element.outerHTML is missing attribute prefixes in some cases in HTML documents

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Element.outerHTML is missing attribute prefixes in some cases in HTML documents.

[Chris Dumez]

Created attachment 375181 [details]
WIP Patch

[Chris Dumez]

Created attachment 375187 [details]
WIP Patch

[Chris Dumez]

Created attachment 375189 [details]
WIP Patch

[Chris Dumez]

Created attachment 375190 [details]
Patch

[Chris Dumez]

Created attachment 375194 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 375194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375194&action=review

> Source/WebCore/editing/MarkupAccumulator.cpp:562
> +            AtomStringImpl* foundNS = namespaces && attribute.prefix().impl() ? namespaces->get(attribute.prefix().impl()) : 0;

I know you're just moving code around but maybe use nullptr?

> Source/WebCore/editing/MarkupAccumulator.cpp:565
> +                if (AtomStringImpl* prefix = namespaces ? namespaces->get(attribute.namespaceURI().impl()) : 0)

Ditto.

[Chris Dumez]

(In reply to Ryosuke Niwa from comment #6)
> Comment on attachment 375194 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375194&action=review
> 
> > Source/WebCore/editing/MarkupAccumulator.cpp:562
> > +            AtomStringImpl* foundNS = namespaces && attribute.prefix().impl() ? namespaces->get(attribute.prefix().impl()) : 0;
> 
> I know you're just moving code around but maybe use nullptr?
> 
> > Source/WebCore/editing/MarkupAccumulator.cpp:565
> > +                if (AtomStringImpl* prefix = namespaces ? namespaces->get(attribute.namespaceURI().impl()) : 0)
> 
> Ditto.

Sure thing.

[Chris Dumez]

Committed r248042: <https://trac.webkit.org/changeset/248042>

[Radar WebKit Bug Importer]

<rdar://problem/53762119>