Bug 200282 – [WHLSL] Checker sets wrong type for property access instruction with an ander

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Saam Barati]

...

[Saam Barati]

Created attachment 375180 [details]
WIP

need to write a test and changelog and then it's ready

[Saam Barati]

Created attachment 375183 [details]
patch

[Robin Morisset]

Comment on attachment 375183 [details]
patch

The fix LGTM.

Is there a reason for this large test, instead of using the test harness like most recent WHLSL tests?

[Saam Barati]

(In reply to Robin Morisset from comment #3)
> Comment on attachment 375183 [details]
> patch
> 
> The fix LGTM.
> 
> Is there a reason for this large test, instead of using the test harness
> like most recent WHLSL tests?

Yes, the harness does the boxing/unboxing for us. We haven't taught it how to take in structs AFAIK

[Myles C. Maxfield]

Comment on attachment 375183 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375183&action=review

> LayoutTests/webgpu/whlsl/device-proper-type-checker.html:23
> +compute void computeShader(device Point[] buffer : register(u0), float3 threadID : SV_DispatchThreadID) {
> +    float x = buffer[0].x;
> +    float y = buffer[0].y;
> +    x += 1.0;
> +    y += 1.0;
> +    buffer[0].x = x;
> +    buffer[0].y = y;
> +}

Can't we use the fancy harness for this?

[Saam Barati]

(In reply to Myles C. Maxfield from comment #5)
> Comment on attachment 375183 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375183&action=review
> 
> > LayoutTests/webgpu/whlsl/device-proper-type-checker.html:23
> > +compute void computeShader(device Point[] buffer : register(u0), float3 threadID : SV_DispatchThreadID) {
> > +    float x = buffer[0].x;
> > +    float y = buffer[0].y;
> > +    x += 1.0;
> > +    y += 1.0;
> > +    buffer[0].x = x;
> > +    buffer[0].y = y;
> > +}
> 
> Can't we use the fancy harness for this?

See above.

[WebKit Commit Bot]

Comment on attachment 375183 [details]
patch

Clearing flags on attachment: 375183

Committed r248022: <https://trac.webkit.org/changeset/248022>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53734700>