Bug 200281 - [WHLSL] Make ASTDumper dump types and address spaces
Summary: [WHLSL] Make ASTDumper dump types and address spaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-30 14:09 PDT by Saam Barati
Modified: 2019-07-30 16:42 PDT (History)
8 users (show)

See Also:

Attachments
patch (5.60 KB, patch)
2019-07-30 15:21 PDT, Saam Barati 		rmorisset: review+
Details | Formatted Diff | Diff
patch for landing (5.57 KB, patch)
2019-07-30 15:38 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-07-30 14:09:37 PDT 
This was super helpful in debugging things.
Comment 1 Saam Barati 2019-07-30 15:21:31 PDT 
Created attachment 375186 [details]
patch
Comment 2 Robin Morisset 2019-07-30 15:26:02 PDT 
Comment on attachment 375186 [details]
patch

r=me
Comment 3 Saam Barati 2019-07-30 15:38:57 PDT 
Created attachment 375188 [details]
patch for landing
Comment 4 WebKit Commit Bot 2019-07-30 16:41:11 PDT 
Comment on attachment 375188 [details]
patch for landing

Clearing flags on attachment: 375188

Committed r248021: <https://trac.webkit.org/changeset/248021>
Comment 5 WebKit Commit Bot 2019-07-30 16:41:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-30 16:42:15 PDT 
<rdar://problem/53734655>