Bug 200280 - Web Inspector: Console: all navigation items should be shown in the split console
Summary: Web Inspector: Console: all navigation items should be shown in the split con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-30 13:30 PDT by Devin Rousso
Modified: 2019-08-02 14:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.90 KB, patch)
2019-07-30 13:59 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-30 13:30:17 PDT
Right now, only the message source scope bar, GC, and clear buttons are shown.  Since the Console's "Emulate User Gesture" (for example) has a global effect, it should be shown everywhere it could have an effect.
Comment 1 Devin Rousso 2019-07-30 13:59:14 PDT
Created attachment 375173 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-02 13:09:37 PDT
Comment on attachment 375173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375173&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:44
> +        this._inputField.placeholder = " "; // This is necessary for :placeholder-shown.

Interesting!
Comment 3 WebKit Commit Bot 2019-08-02 14:07:13 PDT
Comment on attachment 375173 [details]
Patch

Clearing flags on attachment: 375173

Committed r248180: <https://trac.webkit.org/changeset/248180>
Comment 4 WebKit Commit Bot 2019-08-02 14:07:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-02 14:08:20 PDT
<rdar://problem/53878871>