Bug 200279 - Web Inspector: Console: execution context picker doesn't update when switching to the inferred context from auto
Summary: Web Inspector: Console: execution context picker doesn't update when switchin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-30 13:26 PDT by Devin Rousso
Modified: 2019-08-03 00:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2019-07-30 14:20 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-30 13:26:50 PDT
# STEPS TO REPRODUCE:
1. inspect any page with multiple execution contexts (e.g. <iframe>)
2. make sure the "auto" execution context is selected in the Console
3. try to switch execution contexts to the one that is shown after the "auto - XXX"
 => UI doesn't change ("auto" is still shown)
Comment 1 Devin Rousso 2019-07-30 14:20:53 PDT
Created attachment 375177 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-03 00:07:06 PDT
Comment on attachment 375177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375177&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        and therfore the `RuntimeManager.Event.ActiveExecutionContextChanged` wouldn't fire. In this

Typo "therfore" => "therefore"
Comment 3 WebKit Commit Bot 2019-08-03 00:37:06 PDT
Comment on attachment 375177 [details]
Patch

Clearing flags on attachment: 375177

Committed r248196: <https://trac.webkit.org/changeset/248196>
Comment 4 WebKit Commit Bot 2019-08-03 00:37:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-03 00:38:17 PDT
<rdar://problem/53894836>