RESOLVED FIXED 200274
Analysis task page should show build request author and creation time. 
https://bugs.webkit.org/show_bug.cgi?id=200274
Summary Analysis task page should show build request author and creation time.
dewei_zhu
Reported 2019-07-30 11:14:52 PDT
Analysis task page should show build request author and creation time.
Attachments
Patch (3.50 KB, patch)
2019-07-30 11:18 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-07-30 11:18:01 PDT
Created attachment 375164 [details] Patch
dewei_zhu
Comment 2 2019-07-30 11:18:27 PDT
rdar://43339731
Ryosuke Niwa
Comment 3 2019-07-31 00:12:45 PDT
Comment on attachment 375164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375164&action=review > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:376 > + const requestSummary = `Scheduled${currentGroup.author() ? 'by "' + currentGroup.author() + '"': ''} at ${currentGroup.createdAt()}` Need a space between scheduled & by. Embedding conditions inside a literal expression like this makes impossible to decipher. Please split that into a separate statement as in: const authoredBy = currentGroup.author() ? ' by ' + currentGroup.author() : ''; this.content('request-summary').innerHTML = `Scheduled ${authoredBy} at ${currentGroup.createdAt()}` Multiple whitespaces are automatically collapsed into one by CSS.
dewei_zhu
Comment 4 2019-07-31 09:28:26 PDT
Landed in r248045.
Note You need to log in before you can comment on or make changes to this bug.