Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)

[Simon Fraser (smfr)]

Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)

[Simon Fraser (smfr)]

Created attachment 375137 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/53679408>

[EWS Watchlist]

Attachment 375137 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:57:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 375137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375137&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:56
> +            auto frameSize = [view frame].size;

More dots

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:57
> +            if (frameSize.width == 0 || frameSize.height == 0)

CGRectIsEmpty?

[Simon Fraser (smfr)]

https://trac.webkit.org/r248015