Bug 200258 - imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html is a flakey failure, WebAssembly.Global is not implemented
Summary: imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html is a fla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-29 16:52 PDT by Truitt Savell
Modified: 2019-12-04 12:28 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2019-12-04 00:12 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-07-29 16:52:54 PDT 
It looks like the imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html

added in https://trac.webkit.org/changeset/247457/webkit

is flaky on Mac Debug.
History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fwasm%2Fjsapi%2Finterface.any.worker.html

Diff:
--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-actual.txt
@@ -1,5 +1,3 @@
-CONSOLE MESSAGE: line 1774: TypeError: null is not an object (evaluating 'this.message_target.removeEventListener')
-CONSOLE MESSAGE: line 154: TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype')
 
 Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype')
Comment 1 Radar WebKit Bug Importer 2019-07-29 16:53:27 PDT 
<rdar://problem/53686304>
Comment 2 Yusuke Suzuki 2019-07-29 18:51:48 PDT 
This is imported from wpt, and the error related to `WebAssembly.Global` thing is expected since this is not implemented yet. We can mark it as flaky. When `WebAssembly.Global` is implemented, we can make it PASS.
Comment 3 Truitt Savell 2019-07-30 08:24:36 PDT 
Marked test as flakey in https://trac.webkit.org/changeset/248005/webkit
Comment 4 Alexey Proskuryakov 2019-07-30 15:28:38 PDT 
Curious why an unimplemented feature causes flaky failures, not 100% failures. Is this test racy in some way?
Comment 5 Yusuke Suzuki 2019-12-04 00:06:18 PST 
Let's unmark it since I implemented WebAssembly.Global.
Comment 6 Yusuke Suzuki 2019-12-04 00:12:30 PST 
Created attachment 384792 [details]
Patch
Comment 7 WebKit Commit Bot 2019-12-04 12:28:14 PST 
Comment on attachment 384792 [details]
Patch

Clearing flags on attachment: 384792

Committed r253119: <https://trac.webkit.org/changeset/253119>
Comment 8 WebKit Commit Bot 2019-12-04 12:28:16 PST 
All reviewed patches have been landed.  Closing bug.