Bug 200248 – Owners of MultiChannelResampler should make sure that the output bus given to it has the same number of channels

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

WebAudioSourceProviderAVFObjC should not call its clients for new samples if it is scheduling a task to change the audio format

[youenn fablet]

<rdar://problem/53411051>

[youenn fablet]

Created attachment 375179 [details]
Patch

[EWS Watchlist]

Attachment 375179 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:175:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 375179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375179&action=review

> Source/WebCore/ChangeLog:9
> +        When a track number of channels is changing, MediaStreamAudioSourceNode is expected

Nit: s/track number of channels is changing/track's number of channels changes/

> Source/WebCore/ChangeLog:11
> +        MultiChannelResampler expects to have the same amount of channels as the output

Nit: s/amount/number/

[youenn fablet]

Created attachment 375228 [details]
Patch for landing

[EWS Watchlist]

Attachment 375228 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:175:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 375228 [details]
Patch for landing

Clearing flags on attachment: 375228

Committed r248046: <https://trac.webkit.org/changeset/248046>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.