Bug 200240 – Web Inspector: add -webkit-* keywords for *-height CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

intrinsic
min-intrinsic
min-content (and -webkit-min-content)
max-content (and -webkit-max-content)
-webkit-fill-available
fit-content (and -webkit-fit-content)
auto
none (for max-* only)

[Devin Rousso]

Created attachment 375101 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 375101 [details]
Patch

r=me

[Nikita Vasilyev]

I wonder how feasible it is to make a script to parse & extract keyword values from WebCore/css/CSSValueKeywords.in and store them in a JS/JSON file that can be used by Web Inspector.

[Devin Rousso]

Comment on attachment 375101 [details]
Patch

(In reply to Nikita Vasilyev from comment #3)
> I wonder how feasible it is to make a script to parse & extract keyword values from WebCore/css/CSSValueKeywords.in and store them in a JS/JSON file that can be used by Web Inspector.
CSSValueKeywords.in doesn't have a full mapping of CSS keyword to CSS property.  The same is true of CSSProperties.json.  Ideally, we'd merge the two files and have each property in CSSProperties.json have a list of all the keywords it accepts (which can then be used in place of CSSValueKeywords.in).

In this case, the keywords aren't actually related to any CSS property in either file.  They're checked during style conversion (StyleBuilderConverter.h).

[WebKit Commit Bot]

Comment on attachment 375101 [details]
Patch

Clearing flags on attachment: 375101

Committed r247928: <https://trac.webkit.org/changeset/247928>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53684329>