Bug 200240 - Web Inspector: add -webkit-* keywords for *-height CSS properties
Summary: Web Inspector: add -webkit-* keywords for *-height CSS properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-29 14:02 PDT by Devin Rousso
Modified: 2019-07-29 16:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.44 KB, patch)
2019-07-29 14:12 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-29 14:02:21 PDT
intrinsic
min-intrinsic
min-content (and -webkit-min-content)
max-content (and -webkit-max-content)
-webkit-fill-available
fit-content (and -webkit-fit-content)
auto
none (for max-* only)
Comment 1 Devin Rousso 2019-07-29 14:12:55 PDT
Created attachment 375101 [details]
Patch
Comment 2 Joseph Pecoraro 2019-07-29 14:36:37 PDT
Comment on attachment 375101 [details]
Patch

r=me
Comment 3 Nikita Vasilyev 2019-07-29 14:37:51 PDT
I wonder how feasible it is to make a script to parse & extract keyword values from WebCore/css/CSSValueKeywords.in and store them in a JS/JSON file that can be used by Web Inspector.
Comment 4 Devin Rousso 2019-07-29 15:41:57 PDT
Comment on attachment 375101 [details]
Patch

(In reply to Nikita Vasilyev from comment #3)
> I wonder how feasible it is to make a script to parse & extract keyword values from WebCore/css/CSSValueKeywords.in and store them in a JS/JSON file that can be used by Web Inspector.
CSSValueKeywords.in doesn't have a full mapping of CSS keyword to CSS property.  The same is true of CSSProperties.json.  Ideally, we'd merge the two files and have each property in CSSProperties.json have a list of all the keywords it accepts (which can then be used in place of CSSValueKeywords.in).

In this case, the keywords aren't actually related to any CSS property in either file.  They're checked during style conversion (StyleBuilderConverter.h).
Comment 5 WebKit Commit Bot 2019-07-29 16:06:32 PDT
Comment on attachment 375101 [details]
Patch

Clearing flags on attachment: 375101

Committed r247928: <https://trac.webkit.org/changeset/247928>
Comment 6 WebKit Commit Bot 2019-07-29 16:06:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-29 16:07:17 PDT
<rdar://problem/53684329>