Bug 200239 - Contextual menu does not present when holding an embedded photo but works with link and attachments
Summary: Contextual menu does not present when holding an embedded photo but works wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-29 13:51 PDT by Dean Jackson
Modified: 2019-07-29 14:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.50 KB, patch)
2019-07-29 13:55 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-07-29 13:51:11 PDT 
Contextual menu does not present when holding an embedded photo but works with link and attachments
Comment 1 Dean Jackson 2019-07-29 13:51:44 PDT 
<rdar://problem/53318733>
Comment 2 Dean Jackson 2019-07-29 13:55:03 PDT 
Created attachment 375096 [details]
Patch
Comment 3 Tim Horton 2019-07-29 13:56:42 PDT 
Comment on attachment 375096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7971
> +            UIContextMenuActionProvider actionMenuProvider = [weakSelf = weakSelf, elementInfo = elementInfo] (NSArray<UIMenuElement *> *) -> UIMenu * {

why the [a = a, b = b]? can't you just [a, b]?
Comment 4 Tim Horton 2019-07-29 13:56:55 PDT 
Comment on attachment 375096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7978
> +                return [UIMenu menuWithTitle:@"" children:actions];

Is this not nullable?
Comment 5 Dean Jackson 2019-07-29 14:16:27 PDT 
Comment on attachment 375096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7971
>> +            UIContextMenuActionProvider actionMenuProvider = [weakSelf = weakSelf, elementInfo = elementInfo] (NSArray<UIMenuElement *> *) -> UIMenu * {
> 
> why the [a = a, b = b]? can't you just [a, b]?

yes

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7978
>> +                return [UIMenu menuWithTitle:@"" children:actions];
> 
> Is this not nullable?

Alas, no. Very strange since they don't really want titles.
Comment 6 Dean Jackson 2019-07-29 14:20:46 PDT 
Committed r247920: <https://trac.webkit.org/changeset/247920>