Bug 200236 - Web Inspector: Sources: increase the vertical space allocated to the call stack when paused
Summary: Web Inspector: Sources: increase the vertical space allocated to the call sta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-29 13:26 PDT by Devin Rousso
Modified: 2019-08-09 15:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.03 KB, patch)
2019-07-29 13:57 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (18.02 KB, patch)
2019-07-29 14:11 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-29 13:26:10 PDT 
When paused, usually the most important/useful info is the call stack, so we should give it more space/priority.

On the same idea, when not paused, it's likely that the developer cares more about the resources with breakpoints than those without.
Comment 1 Devin Rousso 2019-07-29 13:57:16 PDT 
Created attachment 375098 [details]
Patch
Comment 2 Devin Rousso 2019-07-29 14:11:14 PDT 
Created attachment 375100 [details]
Patch
Comment 3 Nikita Vasilyev 2019-07-29 14:38:42 PDT 
Screenshot?
Comment 4 Devin Rousso 2019-07-29 15:43:23 PDT 
(In reply to Nikita Vasilyev from comment #3)
> Screenshot?
I didn't include a screenshot because it's highly dependent on the height of the inspector window (flexbox).  The UI looks the exact same, other than that the Call Stack and Breakpoints sections are larger.
Comment 5 Joseph Pecoraro 2019-08-09 14:34:57 PDT 
Comment on attachment 375100 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2019-08-09 14:59:35 PDT 
Comment on attachment 375100 [details]
Patch

Clearing flags on attachment: 375100

Committed r248480: <https://trac.webkit.org/changeset/248480>
Comment 7 WebKit Commit Bot 2019-08-09 14:59:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-09 15:01:25 PDT 
<rdar://problem/54144153>