Bug 200217 - [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
Summary: [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-28 23:27 PDT by Fujii Hironori
Modified: 2019-07-29 18:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.02 KB, patch)
2019-07-28 23:32 PDT, Fujii Hironori 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-28 23:27:22 PDT 
[Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
Comment 1 Fujii Hironori 2019-07-28 23:32:12 PDT 
Created attachment 375065 [details]
Patch
Comment 2 Alex Christensen 2019-07-29 10:37:34 PDT 
Comment on attachment 375065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375065&action=review

> Tools/MiniBrowser/win/MainWindow.cpp:121
> +    m_hReloadButtonWnd = CreateWindow(L"BUTTON", L"âº", WS_CHILD | WS_VISIBLE | BS_TEXT, 0, 0, 0, 0, m_hMainWnd, reinterpret_cast<HMENU>(IDM_RELOAD), hInstance, 0);

I love it. Who needs icons when you have unicode?
Comment 3 Fujii Hironori 2019-07-29 18:54:39 PDT 
Committed r247938: <https://trac.webkit.org/changeset/247938>
Comment 4 Radar WebKit Bug Importer 2019-07-29 18:55:19 PDT 
<rdar://problem/53690325>