Bug 200211 - wpt/css/css-images/gradient/color-stops-parsing.html fails
Summary: wpt/css/css-images/gradient/color-stops-parsing.html fails
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-28 15:54 PDT by Simon Fraser (smfr)
Modified: 2019-08-15 10:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.19 KB, patch)
2019-07-28 16:34 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-28 15:54:28 PDT
wpt/css/css-images/gradient/color-stops-parsing.html fails once the crash (bug 200206) is fixed.
Comment 1 Simon Fraser (smfr) 2019-07-28 15:57:00 PDT
It fails on cases where there are multiple length values not separated by commas:

linear-gradient(black, 25% 50%, white)

Chrome and Firefox pass these tests. The relevant parsing code in Chrome is protected by RuntimeEnabledFeatures::MultipleColorStopPositionsEnabled() which was added via https://chromiumcodereview.appspot.com/2799793002/. I'm not sure if this is enabled by default in Chrome yet.
Comment 2 Florin Malita 2019-07-28 16:31:56 PDT
This was shipped in Chrome m71: https://chromium-review.googlesource.com/c/chromium/src/+/1230018/

(see also https://chromestatus.com/feature/5712111258828800)
Comment 3 Simon Fraser (smfr) 2019-07-28 16:34:14 PDT
Created attachment 375050 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-07-28 16:54:33 PDT
Comment on attachment 375050 [details]
Patch

This breaks a conic gradient test.