Bug 200186 - Force Reveal to always lookup from menu
Summary: Force Reveal to always lookup from menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-26 18:03 PDT by Megan Gardner
Modified: 2019-07-29 12:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2019-07-26 18:05 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2019-07-29 11:41 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2019-07-29 12:00 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-07-26 18:03:47 PDT 
Force Reveal to always lookup from menu
Comment 1 Megan Gardner 2019-07-26 18:05:50 PDT 
Created attachment 375007 [details]
Patch
Comment 2 Tim Horton 2019-07-29 11:34:33 PDT 
plz fix all the typos and grammaros
Comment 3 Megan Gardner 2019-07-29 11:41:20 PDT 
Created attachment 375087 [details]
Patch
Comment 4 Tim Horton 2019-07-29 11:59:05 PDT 
Comment on attachment 375087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375087&action=review

> Source/WebCore/ChangeLog:11
> +        Reveal is not currenlty testable.

😲
Comment 5 Megan Gardner 2019-07-29 12:00:53 PDT 
Created attachment 375088 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-29 12:20:23 PDT 
Comment on attachment 375088 [details]
Patch

Clearing flags on attachment: 375088

Committed r247915: <https://trac.webkit.org/changeset/247915>
Comment 7 WebKit Commit Bot 2019-07-29 12:20:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-29 12:21:18 PDT 
<rdar://problem/53673245>