Bug 200161 - WebSockets: workers never use the platform WebSockets path
Summary: WebSockets: workers never use the platform WebSockets path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 200162
  Show dependency treegraph
 
Reported: 2019-07-26 03:41 PDT by Carlos Garcia Campos
Modified: 2019-07-29 09:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.01 KB, patch)
2019-07-26 03:44 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-07-26 03:41:53 PDT
A WebCore::WebSocketChannel is created unconditionally in WorkerThreadableWebSocketChannel::Peer.
Comment 1 Carlos Garcia Campos 2019-07-26 03:44:34 PDT
Created attachment 374960 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-07-26 23:56:49 PDT
Related a couple bugs that this will hopefully fix.
Comment 3 Carlos Garcia Campos 2019-07-29 02:11:37 PDT
Committed r247902: <https://trac.webkit.org/changeset/247902>
Comment 4 Radar WebKit Bug Importer 2019-07-29 02:13:58 PDT
<rdar://problem/53653192>
Comment 5 Michael Catanzaro 2019-07-29 04:31:32 PDT
I don't think this is related to bug #199906 since that's a Safari bug report and Safari releases are not using the new CFNet WebSockets yet. This could only fix problems in the new codepath, not the old one.

Also bug #193636 predates the new codepath by a lot.

Thanks for looking for possibly-related bugs though!
Comment 6 Alexey Proskuryakov 2019-07-29 09:18:24 PDT
The problem in bug 199906 is that WebSockets in service workers attempt to use in-process loading instead of Networking process. This patch doesn't fix that, but I think that the nature of the issue is similar enough for someone working on that to be aware of this too.