Bug 200152 - [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
Summary: [Win][WK1] The inspected webview window is misplaced after changing Web Inspe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-25 22:16 PDT by Fujii Hironori
Modified: 2019-07-25 23:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2019-07-25 22:28 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-25 22:16:08 PDT 
[Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height

Note: Windows WK1 has a bug Web Inspector frontend window height can't be changed in high DPI at the moment. Use low DPI display to test this bug.

1. Start WK1 MiniBrowser
2. Open Web Inspector
3. Change Web Inspector frontend widow height
4. inspected WebView window is misplaced

In WebInspectorFrontendClient::setAttachedWindowHeight
the size of  m_inspectedWebViewHwnd is changed without taking toolbar height into account.
Comment 1 Fujii Hironori 2019-07-25 22:28:05 PDT 
Created attachment 374939 [details]
Patch
Comment 2 Fujii Hironori 2019-07-25 22:41:55 PDT 
(In reply to Fujii Hironori from comment #0)
> Note: Windows WK1 has a bug Web Inspector frontend window height can't be
> changed in high DPI at the moment. Use low DPI display to test this bug.

Filed this issue: Bug 200153 – [Win][WK1] Can't change Web Inspector frontend height in high DPI
Comment 3 Fujii Hironori 2019-07-25 23:16:08 PDT 
Comment on attachment 374939 [details]
Patch

Clearing flags on attachment: 374939

Committed r247855: <https://trac.webkit.org/changeset/247855>
Comment 4 Fujii Hironori 2019-07-25 23:16:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-07-25 23:17:29 PDT 
<rdar://problem/53575939>