[JSC] Use unalignedLoad for JSRopeString fiber accesses
Created attachment 374930 [details] Patch
Created attachment 374934 [details] Patch
Comment on attachment 374934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374934&action=review r=me > Source/JavaScriptCore/heap/MarkedBlock.h:305 > + // Some of JSCell types assume that the last JSCell in a MarkedBlock has a subsequent memory region (Footer) that can still safely accesible. /accesible/accessed/ > Source/JavaScriptCore/heap/MarkedBlock.h:306 > + // For example, JSRopeString assumes that it can safely access some subsquent bytes of JSRopeString cell. I suggest rephrasing "some subsquent bytes of JSRopeString cell" as "up to 2 bytes beyond the JSRopeString cell".
Comment on attachment 374934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374934&action=review >> Source/JavaScriptCore/heap/MarkedBlock.h:305 >> + // Some of JSCell types assume that the last JSCell in a MarkedBlock has a subsequent memory region (Footer) that can still safely accesible. > > /accesible/accessed/ Fixed. >> Source/JavaScriptCore/heap/MarkedBlock.h:306 >> + // For example, JSRopeString assumes that it can safely access some subsquent bytes of JSRopeString cell. > > I suggest rephrasing "some subsquent bytes of JSRopeString cell" as "up to 2 bytes beyond the JSRopeString cell". Fixed.
Committed r247854: <https://trac.webkit.org/changeset/247854>
<rdar://problem/53574198>