WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
200140
Disabled SVG shapes should not be hit-tested
https://bugs.webkit.org/show_bug.cgi?id=200140
Summary
Disabled SVG shapes should not be hit-tested
Said Abou-Hallawa
Reported
2019-07-25 15:19:19 PDT
Failed WPT test:
http://web-platform-tests.live/svg/shapes/scripted/disabled-shapes-not-hit.svg
When an SVG shape is disabled because of incorrect dimension, this shape should not be hit by Document.elementFromPoint(). Examples for such shapes are: <circle/> <circle r="0"/> <circle r="-10"/> <circle style="r: 0"/> <circle style="r: -10px"/> <circle style="r: calc(-10px)"/>
Attachments
Patch
(165.07 KB, patch)
2019-11-04 12:52 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(166.51 KB, patch)
2019-11-04 17:03 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Patch
(180.58 KB, patch)
2019-11-05 11:07 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2019-11-04 12:52:57 PST
Created
attachment 382762
[details]
Patch
Said Abou-Hallawa
Comment 2
2019-11-04 17:03:02 PST
Created
attachment 382790
[details]
Patch
Said Abou-Hallawa
Comment 3
2019-11-05 11:07:33 PST
Created
attachment 382835
[details]
Patch
WebKit Commit Bot
Comment 4
2019-11-05 12:10:09 PST
Comment on
attachment 382835
[details]
Patch Clearing flags on attachment: 382835 Committed
r252069
: <
https://trac.webkit.org/changeset/252069
>
WebKit Commit Bot
Comment 5
2019-11-05 12:10:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-11-05 12:11:14 PST
<
rdar://problem/56913777
>
Carlos Alberto Lopez Perez
Comment 7
2020-03-16 21:34:42 PDT
Comment on
attachment 382835
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=382835&action=review
> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-08-f-manual.svg:138 > - drawString( "[rect4] " + bbox.x + " " + bbox.y + " " + bbox.width + " " + bbox.height, verifyBBox( bbox, 10, 10, 400, 0, 1 / 65535 )); > + drawString( "[rect4] " + bbox.x + " " + bbox.y + " " + bbox.width + " " + bbox.height, verifyBBox( bbox, 0, 0, 0, 0, 1 / 65535 ));
I wonder about this change? Has it been made on purpose? Has it been exported to WPT? I can't see this change on the original test file in WPT <
https://github.com/web-platform-tests/wpt/blob/master/svg/import/types-dom-08-f-manual.svg?short_path=cd6bbcc#L138
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug