Bug 200140 – Disabled SVG shapes should not be hit-tested

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

Failed WPT test: http://web-platform-tests.live/svg/shapes/scripted/disabled-shapes-not-hit.svg

When an SVG shape is disabled because of incorrect dimension, this shape should not be hit by Document.elementFromPoint(). Examples for such shapes are:

<circle/>
<circle r="0"/>
<circle r="-10"/>
<circle style="r: 0"/>
<circle style="r: -10px"/>
<circle style="r: calc(-10px)"/>

[Said Abou-Hallawa]

Created attachment 382762 [details]
Patch

[Said Abou-Hallawa]

Created attachment 382790 [details]
Patch

[Said Abou-Hallawa]

Created attachment 382835 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382835 [details]
Patch

Clearing flags on attachment: 382835

Committed r252069: <https://trac.webkit.org/changeset/252069>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56913777>

[Carlos Alberto Lopez Perez]

Comment on attachment 382835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382835&action=review

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-08-f-manual.svg:138
> -        drawString( "[rect4] " + bbox.x + " " + bbox.y + " " + bbox.width + " " + bbox.height, verifyBBox( bbox, 10, 10, 400, 0, 1 / 65535 ));
> +        drawString( "[rect4] " + bbox.x + " " + bbox.y + " " + bbox.width + " " + bbox.height, verifyBBox( bbox, 0, 0, 0, 0, 1 / 65535 ));

I wonder about this change? Has it been made on purpose? Has it been exported to WPT?
I can't see this change on the original test file in WPT <https://github.com/web-platform-tests/wpt/blob/master/svg/import/types-dom-08-f-manual.svg?short_path=cd6bbcc#L138>