Bug 200137 - Replace FileSystem::MappedFileData success parameter with returning Optional
Summary: Replace FileSystem::MappedFileData success parameter with returning Optional
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Christopher Reid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-25 14:46 PDT by Christopher Reid
Modified: 2022-03-09 15:13 PST (History)
13 users (show)

See Also:

Attachments
Patch (13.50 KB, patch)
2019-07-25 14:59 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
patch (13.46 KB, patch)
2019-07-25 15:06 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
patch (13.46 KB, patch)
2019-07-25 15:12 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Patch (13.73 KB, patch)
2019-07-25 15:46 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2019-07-25 14:46:12 PDT 
This was suggested as followup in https://bugs.webkit.org/show_bug.cgi?id=199759#c12.
Comment 1 Christopher Reid 2019-07-25 14:59:12 PDT 
Created attachment 374905 [details]
Patch
Comment 2 EWS Watchlist 2019-07-25 15:01:08 PDT 
Attachment 374905 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Christopher Reid 2019-07-25 15:06:40 PDT 
Created attachment 374908 [details]
patch
Comment 4 Christopher Reid 2019-07-25 15:12:09 PDT 
Created attachment 374909 [details]
patch

fixing mac/ios EWS failures
Comment 5 Christopher Reid 2019-07-25 15:46:34 PDT 
Created attachment 374916 [details]
Patch

Fixing mac linker error.
Comment 6 Darin Adler 2019-07-25 16:24:58 PDT 
Comment on attachment 374916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374916&action=review

> Source/JavaScriptCore/runtime/CachedTypes.cpp:195
> +        error = BytecodeCacheError::StandardError(errno);

Not new to this patch, but I worry about the use of "errno" in platform-independent code. Seems like instead of Optional we could use Expected so the error code would be part of the return value rather than in a global variable.