WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 200127
results.webkit.org: Color should be the worst result, count should include all results
https://bugs.webkit.org/show_bug.cgi?id=200127
Summary
results.webkit.org: Color should be the worst result, count should include al...
Jonathan Bedard
Reported
2019-07-25 09:24:57 PDT
Talking to bot watchers, it seems that the fact that the count included only the count of the worst failures as opposed to a count of all failures is a source of confusion. Make it so that the count of failures includes all failures, regardless of type. For example, a test run with 30 crashes, 4 timeouts and 13 ImageDiff failures would be assigned the color purple, but have a count of 47. The current behavior would cause such a run to be assigned the color purple and have a count of 30.
Attachments
Patch
(2.03 KB, patch)
2019-07-25 09:28 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(2.07 KB, patch)
2019-07-25 17:24 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(1.42 KB, patch)
2019-07-26 08:22 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2019-07-25 09:28:57 PDT
Created
attachment 374893
[details]
Patch
Ryan Haddad
Comment 2
2019-07-25 09:53:23 PDT
Agreed, this makes more sense.
Aakash Jain
Comment 3
2019-07-25 16:48:19 PDT
rs=me
Jonathan Bedard
Comment 4
2019-07-25 17:24:39 PDT
Created
attachment 374927
[details]
Patch
WebKit Commit Bot
Comment 5
2019-07-25 18:03:46 PDT
Comment on
attachment 374927
[details]
Patch Clearing flags on attachment: 374927 Committed
r247850
: <
https://trac.webkit.org/changeset/247850
>
WebKit Commit Bot
Comment 6
2019-07-25 18:03:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-07-25 18:04:16 PDT
<
rdar://problem/53568693
>
Jonathan Bedard
Comment 8
2019-07-26 08:22:22 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 9
2019-07-26 08:22:23 PDT
Created
attachment 374962
[details]
Patch
WebKit Commit Bot
Comment 10
2019-07-26 09:08:21 PDT
Comment on
attachment 374962
[details]
Patch Clearing flags on attachment: 374962 Committed
r247863
: <
https://trac.webkit.org/changeset/247863
>
WebKit Commit Bot
Comment 11
2019-07-26 09:08:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug