Bug 200127 - results.webkit.org: Color should be the worst result, count should include all results
Summary: results.webkit.org: Color should be the worst result, count should include al...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-25 09:24 PDT by Jonathan Bedard
Modified: 2019-07-26 09:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2019-07-25 09:28 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2019-07-25 17:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2019-07-26 08:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-07-25 09:24:57 PDT 
Talking to bot watchers, it seems that the fact that the count included only the count of the worst failures as opposed to a count of all failures is a source of confusion. Make it so that the count of failures includes all failures, regardless of type.

For example, a test run with 30 crashes, 4 timeouts and 13 ImageDiff failures would be assigned the color purple, but have a count of 47. The current behavior would cause such a run to be assigned the color purple and have a count of 30.
Comment 1 Jonathan Bedard 2019-07-25 09:28:57 PDT 
Created attachment 374893 [details]
Patch
Comment 2 Ryan Haddad 2019-07-25 09:53:23 PDT 
Agreed, this makes more sense.
Comment 3 Aakash Jain 2019-07-25 16:48:19 PDT 
rs=me
Comment 4 Jonathan Bedard 2019-07-25 17:24:39 PDT 
Created attachment 374927 [details]
Patch
Comment 5 WebKit Commit Bot 2019-07-25 18:03:46 PDT 
Comment on attachment 374927 [details]
Patch

Clearing flags on attachment: 374927

Committed r247850: <https://trac.webkit.org/changeset/247850>
Comment 6 WebKit Commit Bot 2019-07-25 18:03:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-25 18:04:16 PDT 
<rdar://problem/53568693>
Comment 8 Jonathan Bedard 2019-07-26 08:22:22 PDT 
Reopening to attach new patch.
Comment 9 Jonathan Bedard 2019-07-26 08:22:23 PDT 
Created attachment 374962 [details]
Patch
Comment 10 WebKit Commit Bot 2019-07-26 09:08:21 PDT 
Comment on attachment 374962 [details]
Patch

Clearing flags on attachment: 374962

Committed r247863: <https://trac.webkit.org/changeset/247863>
Comment 11 WebKit Commit Bot 2019-07-26 09:08:23 PDT 
All reviewed patches have been landed.  Closing bug.