Bug 200107 - Avoid UI Process hangs when the WebContent process is showing JS prompts / alerts
Summary: Avoid UI Process hangs when the WebContent process is showing JS prompts / al...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 200126
  Show dependency tree / graph
 
Reported: 2019-07-24 19:37 PDT by Chris Dumez
Modified: 2019-07-25 09:11 PDT (History)
7 users (show)

See Also:

Attachments
Patch (29.21 KB, patch)
2019-07-24 19:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (29.20 KB, patch)
2019-07-24 20:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (29.20 KB, patch)
2019-07-24 20:33 PDT, Chris Dumez 		ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-07-24 19:37:53 PDT 
Avoid UI Process hangs when the WebContent process is showing JS prompts / alerts.
Comment 1 Chris Dumez 2019-07-24 19:38:09 PDT 
<rdar://problem/53034592>
Comment 2 Chris Dumez 2019-07-24 19:55:55 PDT 
Created attachment 374853 [details]
Patch
Comment 3 EWS Watchlist 2019-07-24 19:59:30 PDT 
Attachment 374853 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:384:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2019-07-24 20:12:17 PDT 
Created attachment 374857 [details]
Patch
Comment 5 EWS Watchlist 2019-07-24 20:13:52 PDT 
Attachment 374857 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:384:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2019-07-24 20:33:41 PDT 
Created attachment 374859 [details]
Patch
Comment 7 EWS Watchlist 2019-07-24 20:36:12 PDT 
Attachment 374859 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:384:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2019-07-24 21:39:41 PDT 
Comment on attachment 374859 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2019-07-24 21:52:58 PDT 
Comment on attachment 374859 [details]
Patch

Rejecting attachment 374859 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 374859, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12807209
Comment 10 Chris Dumez 2019-07-25 08:42:18 PDT 
Committed r247822: <https://trac.webkit.org/changeset/247822>