Bug 200104 – Web Inspector: allow comments in protocol JSON

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 374844 [details]
Patch

[EWS Watchlist]

Attachment 374844 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/tests/generic/should-strip-comments.json:2:  Expecting property name enclosed in double quotes: line 2 column 5 (char 6)  [json/syntax] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Comment on attachment 374844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374844&action=review

> Source/JavaScriptCore/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:471
> +            Ref<JSON::Object> jsonResult = m_result.releaseNonNull();

Please rebaseline stale results in a separate commit. It doesn't need to be reviewed.

[Blaze Burg]

r=me

[Devin Rousso]

Created attachment 375650 [details]
Patch

[EWS Watchlist]

Attachment 375650 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/tests/generic/should-strip-comments.json:2:  Expecting property name enclosed in double quotes: line 2 column 5 (char 6)  [json/syntax] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 375650 [details]
Patch

Clearing flags on attachment: 375650

Committed r248320: <https://trac.webkit.org/changeset/248320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54006498>

[Devin Rousso]

Rebased inspector generator tests in r248374 <https://trac.webkit.org/r248374>.