Bug 200098 - [WHLSL] UnnamedType should be reference counted
Summary: [WHLSL] UnnamedType should be reference counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-24 15:16 PDT by Saam Barati
Modified: 2019-07-28 19:29 PDT (History)
11 users (show)

See Also:


Attachments
WIP (98.80 KB, patch)
2019-07-24 19:59 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
WIP (142.20 KB, patch)
2019-07-24 20:08 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
WIP (150.50 KB, patch)
2019-07-25 15:57 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (148.60 KB, patch)
2019-07-25 19:11 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-07-24 15:16:48 PDT
We clone them > 433k times in some of Justin's simple demos! That's craziness.
Comment 1 Saam Barati 2019-07-24 18:29:11 PDT
Gonna work on this now
Comment 2 Saam Barati 2019-07-24 19:59:09 PDT
Created attachment 374854 [details]
WIP
Comment 3 Saam Barati 2019-07-24 20:06:34 PDT
seems like 40% speedup on hello-cube.html
Comment 4 Saam Barati 2019-07-24 20:08:59 PDT
Created attachment 374856 [details]
WIP
Comment 5 Saam Barati 2019-07-25 15:57:57 PDT
Created attachment 374918 [details]
WIP

Might be ready. Just want to read it over once.
Comment 6 Saam Barati 2019-07-25 19:11:02 PDT
Created attachment 374931 [details]
patch
Comment 7 EWS Watchlist 2019-07-25 19:13:50 PDT
Attachment 374931 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:958:  'getterReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:971:  'anderReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:988:  'threadAnderReturnType' is incorrectly named. It should be named 'protector' or 'protectedNullptr'.  [readability/naming/protected] [4]
Total errors found: 3 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2019-07-26 14:26:19 PDT
Comment on attachment 374931 [details]
patch

Clearing flags on attachment: 374931

Committed r247878: <https://trac.webkit.org/changeset/247878>
Comment 9 WebKit Commit Bot 2019-07-26 14:26:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Truitt Savell 2019-07-26 17:01:38 PDT
It looks like the changes in https://trac.webkit.org/changeset/247878/webkit

caused testing in webgpu/ to exit early on Mojave Debug with crashes

Build:
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/3784

Results:
https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r247879%20(3784)/results.html

I was able to reproduce this by just running the webgpu/ directory locally.
Comment 11 Saam Barati 2019-07-26 18:37:47 PDT
(In reply to Truitt Savell from comment #10)
> It looks like the changes in https://trac.webkit.org/changeset/247878/webkit
> 
> caused testing in webgpu/ to exit early on Mojave Debug with crashes
> 
> Build:
> https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/
> builds/3784
> 
> Results:
> https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/
> r247879%20(3784)/results.html
> 
> I was able to reproduce this by just running the webgpu/ directory locally.

Looking into it now
Comment 12 Saam Barati 2019-07-26 19:03:34 PDT
I think I have the fix. Just waiting for my local build to finish
Comment 13 Saam Barati 2019-07-26 19:19:02 PDT
fixed in:
https://trac.webkit.org/changeset/247887/webkit
Comment 14 Tim Horton 2019-07-28 19:28:50 PDT
(In reply to Saam Barati from comment #13)
> fixed in:
> https://trac.webkit.org/changeset/247887/webkit

And a follow up in https://trac.webkit.org/changeset/247899/webkit
Comment 15 Radar WebKit Bug Importer 2019-07-28 19:29:09 PDT
<rdar://problem/53644774>