Bug 200097 - [WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
Summary: [WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implemen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-24 14:53 PDT by Justin Fan
Modified: 2019-07-27 17:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (24.25 KB, patch)
2019-07-24 14:58 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (28.84 KB, patch)
2019-07-26 17:29 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-07-24 14:53:37 PDT 
[WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
Comment 1 Justin Fan 2019-07-24 14:58:51 PDT 
Created attachment 374814 [details]
Patch
Comment 2 Justin Fan 2019-07-26 17:29:59 PDT 
Created attachment 375003 [details]
Patch
Comment 3 Myles C. Maxfield 2019-07-26 17:40:36 PDT 
Comment on attachment 375003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375003&action=review

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:-59
> -    ArrayReferenceType(ArrayReferenceType&&) = default;

Why?
Comment 4 Justin Fan 2019-07-26 17:44:07 PDT 
Comment on attachment 375003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375003&action=review

>> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:-59
>> -    ArrayReferenceType(ArrayReferenceType&&) = default;
> 
> Why?

These classes were made RefCounted in a previous patch; remove their move ctors to fix build.
Comment 5 WebKit Commit Bot 2019-07-27 17:47:06 PDT 
Comment on attachment 375003 [details]
Patch

Clearing flags on attachment: 375003

Committed r247892: <https://trac.webkit.org/changeset/247892>
Comment 6 WebKit Commit Bot 2019-07-27 17:47:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-27 17:48:16 PDT 
<rdar://problem/53627743>