RESOLVED FIXED 200082
[iOS] Add a test to ensure that a tap in editable content shows the callout bar if the selection did not change 
https://bugs.webkit.org/show_bug.cgi?id=200082
Summary [iOS] Add a test to ensure that a tap in editable content shows the callout b...
Wenson Hsieh
Reported 2019-07-24 09:48:37 PDT
...WebKit followup to <rdar://problem/53106460>.
Attachments
Patch (3.73 KB, patch)
2019-08-30 08:31 PDT, Wenson Hsieh 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (3.71 KB, patch)
2019-08-31 15:19 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-08-30 08:31:29 PDT
Created attachment 377711 [details] Patch
Dean Jackson
Comment 2 2019-08-31 15:11:54 PDT
Comment on attachment 377711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review > LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25 > + input = document.querySelector("input"); Dodgy way to declare a global :) > LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33 > + await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange"); I find it easier to parse if the arrow function has {}, but up to you.
Wenson Hsieh
Comment 3 2019-08-31 15:17:16 PDT
Comment on attachment 377711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review >> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25 >> + input = document.querySelector("input"); > > Dodgy way to declare a global :) Ok — I’ll declare input outside, instead. >> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33 >> + await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange"); > > I find it easier to parse if the arrow function has {}, but up to you. Sure — I’ll add the {}.
Wenson Hsieh
Comment 4 2019-08-31 15:19:27 PDT
Created attachment 377808 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-08-31 16:02:35 PDT
Comment on attachment 377808 [details] Patch for landing Clearing flags on attachment: 377808 Committed r249363: <https://trac.webkit.org/changeset/249363>
Note You need to log in before you can comment on or make changes to this bug.