Bug 200082 - [iOS] Add a test to ensure that a tap in editable content shows the callout bar if the selection did not change
Summary: [iOS] Add a test to ensure that a tap in editable content shows the callout b...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2019-07-24 09:48 PDT by Wenson Hsieh
Modified: 2019-08-31 16:02 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.73 KB, patch)
2019-08-30 08:31 PDT, Wenson Hsieh
dino: review+
Details | Formatted Diff | Diff
Patch for landing (3.71 KB, patch)
2019-08-31 15:19 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-07-24 09:48:37 PDT
...WebKit followup to <rdar://problem/53106460>.
Comment 1 Wenson Hsieh 2019-08-30 08:31:29 PDT
Created attachment 377711 [details]
Patch
Comment 2 Dean Jackson 2019-08-31 15:11:54 PDT
Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
> +    input = document.querySelector("input");

Dodgy way to declare a global :)

> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");

I find it easier to parse if the arrow function has {}, but up to you.
Comment 3 Wenson Hsieh 2019-08-31 15:17:16 PDT
Comment on attachment 377711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377711&action=review

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:25
>> +    input = document.querySelector("input");
> 
> Dodgy way to declare a global :)

Ok — I’ll declare input outside, instead.

>> LayoutTests/editing/selection/ios/show-callout-bar-after-tap.html:33
>> +    await UIHelper.callFunctionAndWaitForEvent(() => UIHelper.chooseMenuAction("Select All"), document, "selectionchange");
> 
> I find it easier to parse if the arrow function has {}, but up to you.

Sure — I’ll add the {}.
Comment 4 Wenson Hsieh 2019-08-31 15:19:27 PDT
Created attachment 377808 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-08-31 16:02:35 PDT
Comment on attachment 377808 [details]
Patch for landing

Clearing flags on attachment: 377808

Committed r249363: <https://trac.webkit.org/changeset/249363>