Bug 20008 - -webkit-transform should have good initial value
Summary: -webkit-transform should have good initial value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-11 04:55 PDT by Dean Jackson
Modified: 2008-07-18 15:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2008-07-16 21:19 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Updated patch (includes test changes) (2.81 KB, patch)
2008-07-17 12:47 PDT, Dean Jackson
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2008-07-11 04:55:46 PDT
See http://build.webkit.org/results/trunk-mac-ppc-release/13642/fast/css/computed-style-without-renderer-actual.txt
(ignore that the test says it is failing in that report)

-webkit-transform doesn't have a nice value when a parent of display none.
Comment 1 Simon Fraser (smfr) 2008-07-16 20:53:19 PDT
It should return "none" in this case I think (as should an untransformed element).
Comment 2 Simon Fraser (smfr) 2008-07-16 21:19:53 PDT
Created attachment 22329 [details]
Patch

This patch also fixes getComputedStyle() to return 'none' for elements with no tranform (previously, it would return an identity matrix).
Comment 3 Dean Jackson 2008-07-17 12:47:18 PDT
Created attachment 22349 [details]
Updated patch (includes test changes)
Comment 4 Dave Hyatt 2008-07-18 12:17:23 PDT
Comment on attachment 22349 [details]
Updated patch (includes test changes)

Remove the braces from

+    if (!renderer || renderer->style()->transform().isEmpty()) {
+        return CSSPrimitiveValue::createIdentifier(CSSValueNone);
+    }

r=me
Comment 5 Simon Fraser (smfr) 2008-07-18 15:11:29 PDT
Fixed in r35239.