Bug 200067 - Use 12 digits to show a git commit.
Summary: Use 12 digits to show a git commit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dewei_zhu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-23 17:43 PDT by dewei_zhu
Modified: 2019-07-24 10:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2019-07-23 17:46 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2019-07-23 17:43:33 PDT 
Use 12 digits to show a git commit.
Comment 1 dewei_zhu 2019-07-23 17:46:28 PDT 
Created attachment 374744 [details]
Patch
Comment 2 dewei_zhu 2019-07-23 17:47:07 PDT 
rdar://47048358
Comment 3 Jonathan Bedard 2019-07-24 08:11:41 PDT 
I did the math for this a few months back, 8 is way to small and a collision is quite likely given 10's of thousands of commits. If I recall, 12 digits supports what is, in effect, around 100 years worth of WebKit commits at the current rate.
Comment 4 dewei_zhu 2019-07-24 10:10:53 PDT 
Landed in r247770