Bug 200057 - [ews-build] Hide build steps to compress, upload and unzip layout-test-results
Summary: [ews-build] Hide build steps to compress, upload and unzip layout-test-results
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-23 16:19 PDT by Aakash Jain
Modified: 2019-07-24 10:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2019-07-23 16:20 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-23 16:19:14 PDT
Build steps to compress, upload and unzip layout-test-results are just implementation details, and the users don't really need to worry about these steps. We should hide these steps from the UI when these steps are completed successfully. In case of layout-test failure, these three steps are run three times each (for first-run, second-run, and clean-tree-run), so total 9 steps. Hiding these would make the build page less cluttered.
Comment 1 Aakash Jain 2019-07-23 16:20:10 PDT
Created attachment 374729 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-07-23 16:29:35 PDT
I'm skeptical about this one. It's good to have the buildbot page as nice as possible, but we will never make it user friendly. So hiding things that are necessary for understanding and debugging EWS seems like over-shooting.
Comment 4 Jonathan Bedard 2019-07-24 08:38:35 PDT
I'd like to see an example of the old 'cluttered' look for comparison.

I also don't see an obvious way to reveal hidden steps if we wanted to, am I missing something in the buildbot UI?
Comment 5 Aakash Jain 2019-07-24 08:44:38 PDT
(In reply to Jonathan Bedard from comment #4)
> I'd like to see an example of the old 'cluttered' look for comparison.
https://ews-build.webkit-uat.org/#/builders/34/builds/35

> I also don't see an obvious way to reveal hidden steps if we wanted to, am I missing something in the buildbot UI?
Nope, you are right, there is no obvious way to reveal hidden step. For debugging you can get the info through API though.
Comment 6 Jonathan Bedard 2019-07-24 08:55:25 PDT
(In reply to Aakash Jain from comment #5)
> (In reply to Jonathan Bedard from comment #4)
> > I'd like to see an example of the old 'cluttered' look for comparison.
> https://ews-build.webkit-uat.org/#/builders/34/builds/35
> 
> > I also don't see an obvious way to reveal hidden steps if we wanted to, am I missing something in the buildbot UI?
> Nope, you are right, there is no obvious way to reveal hidden step. For
> debugging you can get the info through API though.

It's a shame we can't just collapse steps and make them visible on request.

I don't think these steps actually provide any information, so I don't see a problem hiding then, even if there isn't a way to expose them in the UI. I don't see these steps ever being needed to understand and debug EWS, but perhaps there is an issue don't have in mind.
Comment 7 Aakash Jain 2019-07-24 10:23:00 PDT
> I don't think these steps actually provide any information
Agree, that's what motivated me to write this patch.

> , so I don't see a problem hiding then, even if there isn't a way to expose them in the UI.
> I don't see these steps ever being needed to understand and debug EWS, but
> perhaps there is an issue don't have in mind.
Note that these step would be hidden only when they PASS, so any failures will be visible. 

One issue I can think of is slow (but still working) upload. The step would be visible while it's running, so if it's too slow we could notice it while it's running.
Comment 8 Aakash Jain 2019-07-24 10:23:17 PDT Comment hidden (obsolete)
Comment 9 Aakash Jain 2019-07-24 10:25:24 PDT
(In reply to Alexey Proskuryakov from comment #3)
> I'm skeptical about this one. It's good to have the buildbot page as nice as
> possible, but we will never make it user friendly. So hiding things that are
> necessary for understanding and debugging EWS seems like over-shooting.
Yeah, this one is just to make the buildbot page nicer (hopefully without affecting our ability to debug any issues). We will still be developing another page in https://bugs.webkit.org/show_bug.cgi?id=197522
Comment 10 Alexey Proskuryakov 2019-07-24 10:29:06 PDT
I guess we just disagree about whether hiding information on a page that's primarily meant for debugging is desirable. If this ever confuses anyone even for five minutes, then it doesn't seem worth it to me.
Comment 11 Aakash Jain 2019-07-24 10:40:31 PDT
(In reply to Alexey Proskuryakov from comment #10)
> I guess we just disagree about whether hiding information on a page that's
> primarily meant for debugging is desirable. If this ever confuses anyone
> even for five minutes, then it doesn't seem worth it to me.
ok, let's just skip this patch. The benefit isn't much, and we know atleast one scenario (slow upload) in which this can make it harder to debug issues.