Deprecate WKContextGetWebsiteDataStore
Created attachment 374715 [details] Patch
Comment on attachment 374715 [details] Patch If this API isn't used at all anymore on some group of OS's, wouldn't it be better to remove it completely (but optionally continue to compile it into the binary if needed for some backward-compatible case)?
Comment on attachment 374715 [details] Patch Attachment 374715 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12797239 New failing tests: http/tests/IndexedDB/storage-limit-2.https.html http/tests/IndexedDB/storage-limit-1.https.html
Created attachment 374734 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 374715 [details] > Patch > > If this API isn't used at all anymore on some group of OS's, wouldn't it be > better to remove it completely (but optionally continue to compile it into > the binary if needed for some backward-compatible case)? We still need it in the binary for open source webkit developers running their webkit with shipping safari.
rdar://problem/53476085 needs to be fixed before this.
Created attachment 375472 [details] Patch
Attachment 375472 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 375475 [details] Patch
Attachment 375475 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 375478 [details] Patch
Attachment 375478 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12855871 Number of test failures exceeded the failure limit.
Created attachment 375480 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12855855 Number of test failures exceeded the failure limit.
Created attachment 375481 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375478 [details] Patch Attachment 375478 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12855870 Number of test failures exceeded the failure limit.
Created attachment 375482 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 378224 [details] Patch
Created attachment 378275 [details] Patch
Created attachment 378280 [details] Patch
http://trac.webkit.org/r249614
<rdar://problem/55146336>
http://trac.webkit.org/r249616
http://trac.webkit.org/r249619