Bug 200045 - Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
Summary: Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-23 13:31 PDT by Alex Christensen
Modified: 2019-07-23 17:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.88 KB, patch)
2019-07-23 13:32 PDT, Alex Christensen 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-23 13:31:29 PDT 
Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
Comment 1 Alex Christensen 2019-07-23 13:32:38 PDT 
Created attachment 374705 [details]
Patch
Comment 2 Mark Lam 2019-07-23 14:00:23 PDT 
Comment on attachment 374705 [details]
Patch

LGTM.
Comment 3 Alex Christensen 2019-07-23 14:05:14 PDT 
http://trac.webkit.org/r247745
Comment 4 Radar WebKit Bug Importer 2019-07-23 14:06:18 PDT 
<rdar://problem/53463102>
Comment 5 Aakash Jain 2019-07-23 16:32:52 PDT 
(In reply to Alex Christensen from comment #3)
> http://trac.webkit.org/r247745
This broke API test 'TestWebKitAPI.WKProcessPool.JavaScriptConfiguration' as indicated by EWS.
Comment 6 Ryan Haddad 2019-07-23 17:04:26 PDT 
Rolled out in https://trac.webkit.org/changeset/247757/webkit
Comment 7 Alex Christensen 2019-07-23 17:08:37 PDT 
Re-landed in http://trac.webkit.org/r247759 to fix the internal build.
I will look into the iOS failure right now.
Comment 8 Alex Christensen 2019-07-23 17:48:25 PDT 
http://trac.webkit.org/r247762