Bug 200040 - Enable HAVE_APP_LINKS_WITH_ISENABLED for entire iOS family
Summary: Enable HAVE_APP_LINKS_WITH_ISENABLED for entire iOS family
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-23 12:11 PDT by Keith Rollin
Modified: 2019-07-23 16:01 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2019-07-23 12:35 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2019-07-23 13:27 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2019-07-23 13:29 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-07-23 12:11:33 PDT
This feature was enabled for just iOS, but should be enabled for tvOS and watchOS, too.
Comment 1 Radar WebKit Bug Importer 2019-07-23 12:13:04 PDT
<rdar://problem/53457670>
Comment 2 Keith Rollin 2019-07-23 12:35:26 PDT
Created attachment 374696 [details]
Patch
Comment 3 Tim Horton 2019-07-23 12:41:01 PDT
Comment on attachment 374696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374696&action=review

> Source/WTF/wtf/Platform.h:1562
>  #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1

Do you want this one too?
Comment 4 Keith Rollin 2019-07-23 13:18:47 PDT
Eric, HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO got swept up in this change, enabling it for tvOS and watchOS. Should it actually be kept as iOS-only?
Comment 5 Keith Rollin 2019-07-23 13:24:36 PDT
Eric is on vacation. I'll side with caution and separate the flags.
Comment 6 Keith Rollin 2019-07-23 13:27:49 PDT
Created attachment 374703 [details]
Patch
Comment 7 Keith Rollin 2019-07-23 13:29:26 PDT
Created attachment 374704 [details]
Patch
Comment 8 WebKit Commit Bot 2019-07-23 16:01:32 PDT
Comment on attachment 374704 [details]
Patch

Clearing flags on attachment: 374704

Committed r247754: <https://trac.webkit.org/changeset/247754>
Comment 9 WebKit Commit Bot 2019-07-23 16:01:33 PDT
All reviewed patches have been landed.  Closing bug.