200027 – Reorganize UIScriptController into platform-specific subclasses

Bug 200027 - Reorganize UIScriptController into platform-specific subclasses

Summary: Reorganize UIScriptController into platform-specific subclasses

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Tim Horton

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-07-23 00:14 PDT by Tim Horton
Modified:	2019-07-28 19:12 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (111.34 KB, patch) 2019-07-23 00:14 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (176.74 KB, patch) 2019-07-25 23:48 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (165.03 KB, patch) 2019-07-25 23:55 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (167.38 KB, patch) 2019-07-26 00:46 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (169.50 KB, patch) 2019-07-26 00:54 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (169.67 KB, patch) 2019-07-26 00:58 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (171.17 KB, patch) 2019-07-26 23:42 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (171.31 KB, patch) 2019-07-27 00:46 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (170.16 KB, patch) 2019-07-27 02:02 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (171.39 KB, patch) 2019-07-27 02:34 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews214 for win-future (13.48 MB, application/zip) 2019-07-27 05:18 PDT, EWS Watchlist	no flags	Details
Patch (8.61 KB, patch) 2019-07-27 14:13 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (173.29 KB, patch) 2019-07-27 14:14 PDT, Tim Horton	simon.fraser: review+	Details \| Formatted Diff \| Diff
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Horton 2019-07-23 00:14:01 PDT

Reorganize UIScriptController into platform-specific subclasses

Comment 1 Tim Horton 2019-07-23 00:14:36 PDT

Created attachment 374678 [details]
Patch

Comment 2 Tim Horton 2019-07-23 00:15:26 PDT

Not for review yet, haven't done any platform but mac

Comment 3 EWS Watchlist 2019-07-23 00:17:23 PDT Comment hidden (obsolete)

Attachment 374678 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:26:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.h:26:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:57:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.h:26:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Tim Horton 2019-07-25 23:48:44 PDT

Created attachment 374943 [details]
Patch

Comment 5 EWS Watchlist 2019-07-25 23:50:07 PDT Comment hidden (obsolete)

Attachment 374943 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Tim Horton 2019-07-25 23:55:05 PDT

Created attachment 374945 [details]
Patch

Comment 7 EWS Watchlist 2019-07-25 23:58:18 PDT Comment hidden (obsolete)

Attachment 374945 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Tim Horton 2019-07-26 00:46:55 PDT

Created attachment 374949 [details]
Patch

Comment 9 EWS Watchlist 2019-07-26 00:48:08 PDT Comment hidden (obsolete)

Attachment 374949 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Tim Horton 2019-07-26 00:54:21 PDT

Created attachment 374950 [details]
Patch

Comment 11 EWS Watchlist 2019-07-26 00:56:17 PDT Comment hidden (obsolete)

Attachment 374950 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Tim Horton 2019-07-26 00:58:34 PDT

Created attachment 374951 [details]
Patch

Comment 13 EWS Watchlist 2019-07-26 01:01:29 PDT Comment hidden (obsolete)

Attachment 374951 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 14 Tim Horton 2019-07-26 23:42:05 PDT

Created attachment 375017 [details]
Patch

Comment 15 EWS Watchlist 2019-07-26 23:43:14 PDT Comment hidden (obsolete)

Attachment 375017 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 16 Tim Horton 2019-07-27 00:46:04 PDT

Created attachment 375021 [details]
Patch

Comment 17 EWS Watchlist 2019-07-27 00:47:38 PDT Comment hidden (obsolete)

Attachment 375021 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 Tim Horton 2019-07-27 02:02:53 PDT

Created attachment 375023 [details]
Patch

Comment 19 EWS Watchlist 2019-07-27 02:04:12 PDT Comment hidden (obsolete)

Attachment 375023 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 20 Tim Horton 2019-07-27 02:34:17 PDT

Created attachment 375025 [details]
Patch

Comment 21 EWS Watchlist 2019-07-27 02:37:20 PDT Comment hidden (obsolete)

Attachment 375025 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 22 EWS Watchlist 2019-07-27 05:18:07 PDT Comment hidden (obsolete)

Comment on attachment 375025 [details]
Patch

Attachment 375025 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12821280

New failing tests:
fast/events/autoscroll-when-input-is-offscreen.html
fast/events/autoscroll-with-software-keyboard.html
fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html
fast/visual-viewport/client-rects-relative-to-layout-viewport.html
pageoverlay/overlay-remove-reinsert-view.html

Comment 23 EWS Watchlist 2019-07-27 05:18:11 PDT Comment hidden (obsolete)

Created attachment 375029 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 24 Tim Horton 2019-07-27 14:13:12 PDT

Created attachment 375033 [details]
Patch

Comment 25 Tim Horton 2019-07-27 14:14:22 PDT

Created attachment 375034 [details]
Patch

Comment 26 EWS Watchlist 2019-07-27 14:15:43 PDT Comment hidden (obsolete)

Attachment 375034 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:174:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:826:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:836:  Extra space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 27 Tim Horton 2019-07-27 15:33:12 PDT

FINALLY

Comment 28 Simon Fraser (smfr) 2019-07-28 13:25:07 PDT

Comment on attachment 375034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375034&action=review

> Tools/ChangeLog:8
> +        Instead of a mishmosh of #ifdefs and extraneous empty functions,

mishmash? pishposh? oshkosh?

> LayoutTests/swipe/resources/swipe-test.js:68
> +        // FIXME: This test should probably not log playEventStream if it doesn't.

doesn't what?

Comment 29 Tim Horton 2019-07-28 19:00:24 PDT

(In reply to Simon Fraser (smfr) from comment #28)
> Comment on attachment 375034 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375034&action=review
> 
> > Tools/ChangeLog:8
> > +        Instead of a mishmosh of #ifdefs and extraneous empty functions,
> 
> mishmash? pishposh? oshkosh?

Probably all of the above.

> > LayoutTests/swipe/resources/swipe-test.js:68
> > +        // FIXME: This test should probably not log playEventStream if it doesn't.
> 
> doesn't what?

... if it doesn't playEventStream!

Comment 30 Tim Horton 2019-07-28 19:11:34 PDT

https://trac.webkit.org/changeset/247898/webkit

Comment 31 Radar WebKit Bug Importer 2019-07-28 19:12:23 PDT

<rdar://problem/53644413>