RESOLVED FIXED 200027
Reorganize UIScriptController into platform-specific subclasses
https://bugs.webkit.org/show_bug.cgi?id=200027
Summary Reorganize UIScriptController into platform-specific subclasses
Tim Horton
Reported 2019-07-23 00:14:01 PDT
Reorganize UIScriptController into platform-specific subclasses
Attachments
Patch (111.34 KB, patch)
2019-07-23 00:14 PDT, Tim Horton
no flags
Patch (176.74 KB, patch)
2019-07-25 23:48 PDT, Tim Horton
no flags
Patch (165.03 KB, patch)
2019-07-25 23:55 PDT, Tim Horton
no flags
Patch (167.38 KB, patch)
2019-07-26 00:46 PDT, Tim Horton
no flags
Patch (169.50 KB, patch)
2019-07-26 00:54 PDT, Tim Horton
no flags
Patch (169.67 KB, patch)
2019-07-26 00:58 PDT, Tim Horton
no flags
Patch (171.17 KB, patch)
2019-07-26 23:42 PDT, Tim Horton
no flags
Patch (171.31 KB, patch)
2019-07-27 00:46 PDT, Tim Horton
no flags
Patch (170.16 KB, patch)
2019-07-27 02:02 PDT, Tim Horton
no flags
Patch (171.39 KB, patch)
2019-07-27 02:34 PDT, Tim Horton
no flags
Archive of layout-test-results from ews214 for win-future (13.48 MB, application/zip)
2019-07-27 05:18 PDT, EWS Watchlist
no flags
Patch (8.61 KB, patch)
2019-07-27 14:13 PDT, Tim Horton
no flags
Patch (173.29 KB, patch)
2019-07-27 14:14 PDT, Tim Horton
simon.fraser: review+
Tim Horton
Comment 1 2019-07-23 00:14:36 PDT
Tim Horton
Comment 2 2019-07-23 00:15:26 PDT
Not for review yet, haven't done any platform but mac
EWS Watchlist
Comment 3 2019-07-23 00:17:23 PDT Comment hidden (obsolete)
Tim Horton
Comment 4 2019-07-25 23:48:44 PDT
EWS Watchlist
Comment 5 2019-07-25 23:50:07 PDT Comment hidden (obsolete)
Tim Horton
Comment 6 2019-07-25 23:55:05 PDT
EWS Watchlist
Comment 7 2019-07-25 23:58:18 PDT Comment hidden (obsolete)
Tim Horton
Comment 8 2019-07-26 00:46:55 PDT
EWS Watchlist
Comment 9 2019-07-26 00:48:08 PDT Comment hidden (obsolete)
Tim Horton
Comment 10 2019-07-26 00:54:21 PDT
EWS Watchlist
Comment 11 2019-07-26 00:56:17 PDT Comment hidden (obsolete)
Tim Horton
Comment 12 2019-07-26 00:58:34 PDT
EWS Watchlist
Comment 13 2019-07-26 01:01:29 PDT Comment hidden (obsolete)
Tim Horton
Comment 14 2019-07-26 23:42:05 PDT
EWS Watchlist
Comment 15 2019-07-26 23:43:14 PDT Comment hidden (obsolete)
Tim Horton
Comment 16 2019-07-27 00:46:04 PDT
EWS Watchlist
Comment 17 2019-07-27 00:47:38 PDT Comment hidden (obsolete)
Tim Horton
Comment 18 2019-07-27 02:02:53 PDT
EWS Watchlist
Comment 19 2019-07-27 02:04:12 PDT Comment hidden (obsolete)
Tim Horton
Comment 20 2019-07-27 02:34:17 PDT
EWS Watchlist
Comment 21 2019-07-27 02:37:20 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 22 2019-07-27 05:18:07 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 23 2019-07-27 05:18:11 PDT Comment hidden (obsolete)
Tim Horton
Comment 24 2019-07-27 14:13:12 PDT
Tim Horton
Comment 25 2019-07-27 14:14:22 PDT
EWS Watchlist
Comment 26 2019-07-27 14:15:43 PDT Comment hidden (obsolete)
Tim Horton
Comment 27 2019-07-27 15:33:12 PDT
FINALLY
Simon Fraser (smfr)
Comment 28 2019-07-28 13:25:07 PDT
Comment on attachment 375034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375034&action=review > Tools/ChangeLog:8 > + Instead of a mishmosh of #ifdefs and extraneous empty functions, mishmash? pishposh? oshkosh? > LayoutTests/swipe/resources/swipe-test.js:68 > + // FIXME: This test should probably not log playEventStream if it doesn't. doesn't what?
Tim Horton
Comment 29 2019-07-28 19:00:24 PDT
(In reply to Simon Fraser (smfr) from comment #28) > Comment on attachment 375034 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375034&action=review > > > Tools/ChangeLog:8 > > + Instead of a mishmosh of #ifdefs and extraneous empty functions, > > mishmash? pishposh? oshkosh? Probably all of the above. > > LayoutTests/swipe/resources/swipe-test.js:68 > > + // FIXME: This test should probably not log playEventStream if it doesn't. > > doesn't what? ... if it doesn't playEventStream!
Tim Horton
Comment 30 2019-07-28 19:11:34 PDT
Radar WebKit Bug Importer
Comment 31 2019-07-28 19:12:23 PDT
Note You need to log in before you can comment on or make changes to this bug.