Bug 200024 – [bmalloc] Each IsoPage gets 1MB VA because VMHeap::tryAllocateLargeChunk rounds up

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Yusuke Suzuki]

Finally, we found the issue!

[Yusuke Suzuki]

<rdar://problem/53275201>

[Yusuke Suzuki]

Created attachment 374665 [details]
Patch

[Saam Barati]

Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

> Source/bmalloc/bmalloc/IsoPage.cpp:35
> +    return tryVMAllocate(pageSize, pageSize, VMTag::IsoHeap);

👌

[Mark Lam]

Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

> Source/WebCore/page/ResourceUsageOverlay.h:61
> -    static const int normalHeight = 160;
> +    static const int normalHeight = 180;

Is this necessary?

[Yusuke Suzuki]

Comment on attachment 374665 [details]
Patch

Thanks! Landing.

[Yusuke Suzuki]

Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

>> Source/WebCore/page/ResourceUsageOverlay.h:61
>> +    static const int normalHeight = 180;
> 
> Is this necessary?

Without this change, ResourceOverlay failed to show all the categories since now we added IsoHeap data line :)

[Yusuke Suzuki]

Committed r247714: <https://trac.webkit.org/changeset/247714>

[Yusuke Suzuki]

*** Bug 202045 has been marked as a duplicate of this bug. ***