Bug 200024 - [bmalloc] Each IsoPage gets 1MB VA because VMHeap::tryAllocateLargeChunk rounds up
Summary: [bmalloc] Each IsoPage gets 1MB VA because VMHeap::tryAllocateLargeChunk roun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 202045 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-22 18:46 PDT by Yusuke Suzuki
Modified: 2019-09-21 02:09 PDT (History)
13 users (show)

See Also:

Attachments
Patch (14.10 KB, patch)
2019-07-22 19:30 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-07-22 18:46:32 PDT 
Finally, we found the issue!
Comment 1 Yusuke Suzuki 2019-07-22 18:46:57 PDT 
<rdar://problem/53275201>
Comment 2 Yusuke Suzuki 2019-07-22 19:30:50 PDT 
Created attachment 374665 [details]
Patch
Comment 3 Saam Barati 2019-07-22 19:37:18 PDT 
Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

> Source/bmalloc/bmalloc/IsoPage.cpp:35
> +    return tryVMAllocate(pageSize, pageSize, VMTag::IsoHeap);

👌
Comment 4 Mark Lam 2019-07-22 19:38:29 PDT 
Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

> Source/WebCore/page/ResourceUsageOverlay.h:61
> -    static const int normalHeight = 160;
> +    static const int normalHeight = 180;

Is this necessary?
Comment 5 Yusuke Suzuki 2019-07-22 19:39:47 PDT 
Comment on attachment 374665 [details]
Patch

Thanks! Landing.
Comment 6 Yusuke Suzuki 2019-07-22 19:40:49 PDT 
Comment on attachment 374665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374665&action=review

>> Source/WebCore/page/ResourceUsageOverlay.h:61
>> +    static const int normalHeight = 180;
> 
> Is this necessary?

Without this change, ResourceOverlay failed to show all the categories since now we added IsoHeap data line :)
Comment 7 Yusuke Suzuki 2019-07-22 19:43:19 PDT 
Committed r247714: <https://trac.webkit.org/changeset/247714>
Comment 8 Yusuke Suzuki 2019-09-21 02:09:08 PDT 
*** Bug 202045 has been marked as a duplicate of this bug. ***