Bug 200020 - Make NetworkSession no longer RefCounted
Summary: Make NetworkSession no longer RefCounted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-22 17:13 PDT by youenn fablet
Modified: 2019-07-26 09:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (27.73 KB, patch)
2019-07-22 17:30 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (30.41 KB, patch)
2019-07-22 18:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (30.76 KB, patch)
2019-07-24 14:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (30.76 KB, patch)
2019-07-24 14:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-22 17:13:55 PDT 
This will simplify the object management model.
Comment 1 youenn fablet 2019-07-22 17:30:09 PDT 
Created attachment 374658 [details]
Patch
Comment 2 youenn fablet 2019-07-22 18:53:35 PDT 
Created attachment 374663 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2019-07-23 10:09:27 PDT 
<rdar://problem/53451361>
Comment 4 Alex Christensen 2019-07-23 13:00:16 PDT 
Comment on attachment 374663 [details]
Patch

I like it.
Comment 5 youenn fablet 2019-07-23 20:23:02 PDT 
I probably am missing some if(m_networkSession).
@cgarcia, could you look whether some are missing in GTK code?
Comment 6 Carlos Garcia Campos 2019-07-24 06:24:11 PDT 
We need for sure a null check in the NetworkDataTask destructor, but I wonder if we need it everywhere m_session is used, or only in async completion handlers?
Comment 7 youenn fablet 2019-07-24 14:23:56 PDT 
Created attachment 374810 [details]
Patch
Comment 8 youenn fablet 2019-07-24 14:25:15 PDT 
Created attachment 374811 [details]
Patch
Comment 9 WebKit Commit Bot 2019-07-25 11:17:26 PDT 
Comment on attachment 374811 [details]
Patch

Clearing flags on attachment: 374811

Committed r247831: <https://trac.webkit.org/changeset/247831>
Comment 10 WebKit Commit Bot 2019-07-25 11:17:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Carlos Alberto Lopez Perez 2019-07-25 14:11:09 PDT 
(In reply to WebKit Commit Bot from comment #9)
> Comment on attachment 374811 [details]
> Patch
> 
> Clearing flags on attachment: 374811
> 
> Committed r247831: <https://trac.webkit.org/changeset/247831>

Seems this broke GTK Debug build:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/23203/steps/compile-webkit/logs/stdio
Comment 12 Carlos Garcia Campos 2019-07-26 00:54:51 PDT 
(In reply to Carlos Alberto Lopez Perez from comment #11)
> (In reply to WebKit Commit Bot from comment #9)
> > Comment on attachment 374811 [details]
> > Patch
> > 
> > Clearing flags on attachment: 374811
> > 
> > Committed r247831: <https://trac.webkit.org/changeset/247831>
> 
> Seems this broke GTK Debug build:
> 
> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/
> builds/23203/steps/compile-webkit/logs/stdio

Fixed in r247856: <https://trac.webkit.org/changeset/247856>
Comment 13 youenn fablet 2019-07-26 09:20:10 PDT 
Thanks!