Discovered this in a certain testing configuration. In practice, it's not actually a problem for real instances (at least right now) because we have to declare where all the changelogs are.
Created attachment 374639 [details]
Comment on attachment 374639 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=374639&action=review
What happens if current commit doesn't have ChangeLog?
> if len(current_response.text) == (len(previous_response.text) if previous_response else 0):
can we simplify this if-else, this is super confusing. Especially if someone doesn't pay very close attention to the order of parenthesis, this doesn't make sense.
> + if not previous_response or len(current_response.text) < len(previous_response.text):
Maybe just add another variable previous_response_length and evaluate it beforehand, so as to simplify both the if-else. something like:
previous_response_length = 0
previous_response_length = len(previous_response.text)
Created attachment 374645 [details]
Comment on attachment 374645 [details]
Clearing flags on attachment: 374645
Committed r247706: <https://trac.webkit.org/changeset/247706>
All reviewed patches have been landed. Closing bug.