Bug 200015 – resultsdbpy: Handle case where the previous commit doesn't have the changelog

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Discovered this in a certain testing configuration. In practice, it's not actually a problem for real instances (at least right now) because we have to declare where all the changelogs are.

[Jonathan Bedard]

Created attachment 374639 [details]
Patch

[Aakash Jain]

Comment on attachment 374639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374639&action=review

What happens if current commit doesn't have ChangeLog?

> Tools/resultsdbpy/resultsdbpy/model/repository.py:323
>                      if len(current_response.text) == (len(previous_response.text) if previous_response else 0):

can we simplify this if-else, this is super confusing. Especially if someone doesn't pay very close attention to the order of parenthesis, this doesn't make sense.

> Tools/resultsdbpy/resultsdbpy/model/repository.py:326
> +                    if not previous_response or len(current_response.text) < len(previous_response.text):

Maybe just add another variable previous_response_length and evaluate it beforehand, so as to simplify both the if-else. something like:

previous_response_length = 0
if previous_response:
     previous_response_length = len(previous_response.text)

[Jonathan Bedard]

Created attachment 374645 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374645 [details]
Patch

Clearing flags on attachment: 374645

Committed r247706: <https://trac.webkit.org/changeset/247706>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53423137>