199986 – Use ObjectIdentifier<FrameIdentifierType> for frameIDs

RESOLVED FIXED 199986

Use ObjectIdentifier<FrameIdentifierType> for frameIDs

https://bugs.webkit.org/show_bug.cgi?id=199986

Summary Use ObjectIdentifier<FrameIdentifierType> for frameIDs

Simon Fraser (smfr)

Reported 2019-07-20 21:01:16 PDT

Use ObjectIdentifier<FrameIdentifierType> for frameIDs

Attachments
Patch (418.88 KB, patch) 2019-07-20 21:05 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (418.82 KB, patch) 2019-08-14 12:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (418.90 KB, patch) 2019-08-14 12:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (420.10 KB, patch) 2019-08-14 12:59 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (428.32 KB, patch) 2019-08-14 13:05 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (428.41 KB, patch) 2019-08-14 13:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (432.54 KB, patch) 2019-08-14 13:42 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (433.01 KB, patch) 2019-08-14 14:13 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (433.61 KB, patch) 2019-08-14 14:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (434.30 KB, patch) 2019-08-14 15:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (433.36 KB, patch) 2019-08-14 15:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (434.61 KB, patch) 2019-08-14 16:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (438.31 KB, patch) 2019-08-14 22:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (453.16 KB, patch) 2019-08-14 22:41 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (453.17 KB, patch) 2019-08-15 07:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-07-20 21:05:44 PDT

Created attachment 374566 [details] Patch

Simon Fraser (smfr)

Comment 2 2019-07-20 21:07:33 PDT

This currently asserts when it tries to IPC FrameIdentifiers with a zero value. We should convert all those call sites to Optional<FrameIdentifier>.

Chris Dumez

Comment 3 2019-08-14 12:43:34 PDT

Created attachment 376295 [details] Patch

EWS Watchlist

Comment 4 2019-08-14 12:45:13 PDT

Attachment 376295 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 6 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 5 2019-08-14 12:51:02 PDT

Created attachment 376298 [details] Patch

EWS Watchlist

Comment 6 2019-08-14 12:54:43 PDT

Attachment 376298 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 6 in 106 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 7 2019-08-14 12:59:56 PDT

Created attachment 376301 [details] Patch

EWS Watchlist

Comment 8 2019-08-14 13:03:16 PDT

Attachment 376301 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 6 in 107 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 9 2019-08-14 13:05:48 PDT

Created attachment 376302 [details] Patch

EWS Watchlist

Comment 10 2019-08-14 13:08:46 PDT

Attachment 376302 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 10 in 110 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 11 2019-08-14 13:16:32 PDT

Created attachment 376303 [details] Patch

EWS Watchlist

Comment 12 2019-08-14 13:19:27 PDT

Attachment 376303 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 10 in 110 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 13 2019-08-14 13:42:45 PDT

Created attachment 376305 [details] Patch

EWS Watchlist

Comment 14 2019-08-14 13:46:11 PDT

Attachment 376305 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 113 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 15 2019-08-14 14:13:05 PDT

Created attachment 376307 [details] Patch

EWS Watchlist

Comment 16 2019-08-14 14:14:33 PDT

Attachment 376307 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 114 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 17 2019-08-14 14:34:36 PDT

Created attachment 376309 [details] Patch

EWS Watchlist

Comment 18 2019-08-14 14:37:56 PDT

Attachment 376309 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 115 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 19 2019-08-14 15:11:14 PDT

Created attachment 376318 [details] Patch

EWS Watchlist

Comment 20 2019-08-14 15:14:15 PDT

Attachment 376318 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 21 2019-08-14 15:36:52 PDT

Created attachment 376322 [details] Patch

EWS Watchlist

Comment 22 2019-08-14 15:39:42 PDT

Attachment 376322 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 115 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 23 2019-08-14 15:54:15 PDT

Comment on attachment 376322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376322&action=review > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:316 > +// FIXME: These callbacks should take Optional<WebCore::FrameIdentifier>. Will take a look into this.

Chris Dumez

Comment 24 2019-08-14 16:06:36 PDT

Created attachment 376329 [details] Patch

EWS Watchlist

Comment 25 2019-08-14 16:10:28 PDT

Attachment 376329 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 115 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 26 2019-08-14 18:33:25 PDT

Comment on attachment 376329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376329&action=review > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:208 > - return 0; > + return FrameIdentifier { }; // This is explicitly zero; see webkit.org/b/159777. Instead of just saying webkit.org/b/159777. Can we also add a comment about how this is a race with the main frame's creation? Also, using 0 is quite subtle since that's also the default value of ObjectIdentifier. I wonder if we can use some other explicit value. e.g. max()-1 since max() is used for hash deleted value.

Chris Dumez

Comment 27 2019-08-14 22:01:32 PDT

Created attachment 376353 [details] Patch

EWS Watchlist

Comment 28 2019-08-14 22:04:35 PDT

Attachment 376353 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1460: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 29 2019-08-14 22:05:54 PDT

(In reply to Ryosuke Niwa from comment #26) > Comment on attachment 376329 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376329&action=review > > > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:208 > > - return 0; > > + return FrameIdentifier { }; // This is explicitly zero; see webkit.org/b/159777. > > Instead of just saying webkit.org/b/159777. > Can we also add a comment about how this is a race with the main frame's > creation? > > Also, using 0 is quite subtle since that's also the default value of > ObjectIdentifier. > I wonder if we can use some other explicit value. > e.g. max()-1 since max() is used for hash deleted value. Agreed, will look into clarifying this code before landing. Maybe returning a std::expected<Optional<FrameIdentifier>, error_type> so we can use WTF::nullopt to mean *main frame* and still deal with errors.

Chris Dumez

Comment 30 2019-08-14 22:41:33 PDT

Created attachment 376356 [details] Patch

EWS Watchlist

Comment 31 2019-08-14 22:43:55 PDT

Attachment 376356 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1465: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 118 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 32 2019-08-15 07:43:47 PDT

Created attachment 376377 [details] Patch

EWS Watchlist

Comment 33 2019-08-15 07:45:42 PDT

Attachment 376377 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1465: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/ChromeClient.h:490: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:491: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:46: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:47: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:52: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.h:54: The parameter name "frameID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/UIProcess/Automation/WebAutomationSession.h:156: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/API/APIFrameInfo.cpp:58: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:35: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 118 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 34 2019-08-15 08:35:44 PDT

Comment on attachment 376377 [details] Patch Clearing flags on attachment: 376377 Committed r248713: <https://trac.webkit.org/changeset/248713>

WebKit Commit Bot

Comment 35 2019-08-15 08:35:46 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 36 2019-08-15 08:36:19 PDT

<rdar://problem/54347183>

Chris Dumez

Comment 37 2019-08-15 08:58:49 PDT

Follow-up WinCairo build fix: <https://trac.webkit.org/changeset/248714>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Chris Dumez

Reported

2019-07-20 21:01 PDT

Modified

2019-08-22 05:15 PDT History

CC List

11 users Show

URL

Keywords InRadar

Depends on

200793

Blocks

Dependencies

tree graph