Bug 199984 – Legacy numeric literals should not permit separators or BigInt

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

Legacy numeric literals should not permit separators or BigInt

[Ross Kirsling]

Created attachment 374564 [details]
Patch

[Ross Kirsling]

An easily-overlooked piece of the spec -- Test262 cases were added for separators yesterday (https://github.com/tc39/test262/pull/2245) but I think they're still needed for BigInt.

[Ross Kirsling]

(In reply to Ross Kirsling from comment #2)
> An easily-overlooked piece of the spec -- Test262 cases were added for
> separators yesterday (https://github.com/tc39/test262/pull/2245) but I think
> they're still needed for BigInt.

The rest of the test cases are in https://github.com/tc39/test262/pull/2253 (with additional BigInt + separator ones in https://github.com/tc39/test262/pull/2252).

One way or another, the key is that neither proposal is meant to add to Annex B.1.1's LegacyOctalIntegerLiteral and NonOctalDecimalIntegerLiteral.

[Caio Lima]

Comment on attachment 374564 [details]
Patch

LGTM

[Keith Miller]

Comment on attachment 374564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374564&action=review

r=me.

> Source/JavaScriptCore/parser/Lexer.cpp:1628
> +    bool isLegacyLiteral = m_buffer8.size();

For clarity can you add:

ASSERT(!m_buffer8.size() || (m_buffer8.size() == 1 && m_buffer[0] == '0'));

[Keith Miller]

Comment on attachment 374564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374564&action=review

> JSTests/stress/numeric-literal-separators.js:75
> +shouldThrow('010000000000_1', SyntaxError);
> +shouldThrow('010000000000_9', SyntaxError);
> +shouldThrow('090000000000_1', SyntaxError);

Can you add tests for 0100_004 and 0_000 etc?

[Ross Kirsling]

Created attachment 374900 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 374900 [details]
Patch for landing

Clearing flags on attachment: 374900

Committed r247845: <https://trac.webkit.org/changeset/247845>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53566528>