RESOLVED FIXED 199983
[iOS WK2] Make a strongly-typed TransactionID to replace uint64_t transactionIDs 
https://bugs.webkit.org/show_bug.cgi?id=199983
Summary [iOS WK2] Make a strongly-typed TransactionID to replace uint64_t transactionIDs
Simon Fraser (smfr)
Reported 2019-07-20 13:49:45 PDT
[iOS WK2] Make a strongly-typed TransactionID to replace uint64_t transactionIDs
Attachments
Patch (38.38 KB, patch)
2019-07-20 13:53 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
Patch (39.93 KB, patch)
2019-07-28 20:13 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (40.07 KB, patch)
2019-08-25 21:32 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-07-20 13:53:23 PDT
Created attachment 374563 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-07-20 13:54:51 PDT
Comment on attachment 374563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374563&action=review > Source/WebKit/Shared/TransactionID.h:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. Oops > Source/WebKit/Shared/TransactionID.h:36 > +template<typename T> class MonotonicObjectIdentifier { Maybe MonotonicObjectIdentifier isn't the right name. I want "always increases by one".
Simon Fraser (smfr)
Comment 3 2019-07-28 20:13:28 PDT
Created attachment 375058 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-08-25 21:32:25 PDT
Created attachment 377226 [details] Patch
WebKit Commit Bot
Comment 5 2019-08-25 23:16:56 PDT
Comment on attachment 377226 [details] Patch Clearing flags on attachment: 377226 Committed r249093: <https://trac.webkit.org/changeset/249093>
Radar WebKit Bug Importer
Comment 6 2019-08-26 15:35:23 PDT
<rdar://problem/54725050>
Darin Adler
Comment 7 2020-05-20 16:42:19 PDT
I’d like to find a way to adjust/tune ObjectIdentifier for this, and retire MonotonicObjectIdentifier.
Simon Fraser (smfr)
Comment 8 2020-05-20 18:57:02 PDT
Maybe we can give ObjectIdentifier a trait for where its static uint64_t lives (shared with other ObjectIdentifiers or not).
Note You need to log in before you can comment on or make changes to this bug.