Bug 199980 - [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
Summary: [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-20 10:45 PDT by Aakash Jain
Modified: 2019-07-22 08:49 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.75 KB, patch)
2019-07-20 10:49 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-20 10:45:50 PDT
ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests, only difference being the build-steps which are invoked on failure.

In https://ews-build.webkit.org/#/builders/18/builds/177 re-run-layout-tests had warnings (flaky tests), which should be considered a SUCCESS, but it was considered a FAILURE (and clean-tree was tested which is inefficient).
Comment 1 Aakash Jain 2019-07-20 10:49:32 PDT
Created attachment 374557 [details]
Patch
Comment 2 Build Bot 2019-07-20 10:50:49 PDT Comment hidden (obsolete)
Comment 3 WebKit Commit Bot 2019-07-22 08:48:42 PDT
Comment on attachment 374557 [details]
Patch

Clearing flags on attachment: 374557

Committed r247683: <https://trac.webkit.org/changeset/247683>
Comment 4 WebKit Commit Bot 2019-07-22 08:48:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-07-22 08:49:18 PDT
<rdar://problem/53399568>