ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests, only difference being the build-steps which are invoked on failure. In https://ews-build.webkit.org/#/builders/18/builds/177 re-run-layout-tests had warnings (flaky tests), which should be considered a SUCCESS, but it was considered a FAILURE (and clean-tree was tested which is inefficient).
Created attachment 374557 [details] Patch
Attachment 374557 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1023: [TestRunWebKitTests.test_parse_results_json_regression] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1024: [TestRunWebKitTests.test_parse_results_json_regression] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1051: [TestRunWebKitTests.test_parse_results_json_flakes] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1052: [TestRunWebKitTests.test_parse_results_json_flakes] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1069: [TestRunWebKitTests.test_parse_results_json_flakes_and_regressions] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1070: [TestRunWebKitTests.test_parse_results_json_flakes_and_regressions] Instance of 'TestRunWebKitTests' has no 'assertEqual' member [pylint/E1101] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 374557 [details] Patch Clearing flags on attachment: 374557 Committed r247683: <https://trac.webkit.org/changeset/247683>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53399568>