Bug 199974 - Make sure the player underlying volume is correctly set after creating a new player
Summary: Make sure the player underlying volume is correctly set after creating a new ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 200005
  Show dependency treegraph
 
Reported: 2019-07-19 17:36 PDT by youenn fablet
Modified: 2019-07-22 13:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (30.04 KB, patch)
2019-07-19 17:49 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (30.08 KB, patch)
2019-07-19 17:58 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (29.99 KB, patch)
2019-07-22 11:19 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-19 17:36:53 PDT
Make sure the player underlying volume is correctly set after creating a new player
Comment 1 youenn fablet 2019-07-19 17:37:30 PDT
<rdar://problem/52762559>
Comment 2 youenn fablet 2019-07-19 17:49:07 PDT
Created attachment 374530 [details]
Patch
Comment 3 Eric Carlson 2019-07-19 17:56:53 PDT
Comment on attachment 374530 [details]
Patch

r=me if the bots are happy with it.
Comment 4 youenn fablet 2019-07-19 17:58:16 PDT
Created attachment 374531 [details]
Patch
Comment 5 youenn fablet 2019-07-19 18:03:08 PDT
While adding effectiveVolume, I did small changes to effectiveMuted.

The effectiveMuted routine now checks for m_mediaController which was not the case before. This slightly change the behaviour in updatePlayState().

In case of m_mediaController , HTMLMediaElement::updateVolume() was setting the player muted state without considering its muted() state (but only m_mediaController and page states).

I believe both changes are correct.
Comment 6 youenn fablet 2019-07-22 11:19:04 PDT
Created attachment 374610 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-07-22 13:03:12 PDT
Comment on attachment 374610 [details]
Patch for landing

Clearing flags on attachment: 374610

Committed r247698: <https://trac.webkit.org/changeset/247698>
Comment 8 WebKit Commit Bot 2019-07-22 13:03:14 PDT
All reviewed patches have been landed.  Closing bug.